Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: ui/webui/resources/PRESUBMIT.py

Issue 2592293002: Require folks to run `git cl format` on ui/webui/resources (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/PRESUBMIT.py
diff --git a/ui/webui/resources/PRESUBMIT.py b/ui/webui/resources/PRESUBMIT.py
index 521ad5e6effce837372b926dba56439f9aab855b..60059c2e14eb371423c8099f1ec85870c43e1512 100644
--- a/ui/webui/resources/PRESUBMIT.py
+++ b/ui/webui/resources/PRESUBMIT.py
@@ -30,11 +30,11 @@ def PostUploadHook(cl, change, output_api):
def CheckChangeOnUpload(input_api, output_api):
- return _CheckForTranslations(input_api, output_api)
+ return _CommonChecks(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
- return _CheckForTranslations(input_api, output_api)
+ return _CommonChecks(input_api, output_api)
def _CheckForTranslations(input_api, output_api):
@@ -68,3 +68,10 @@ def _CheckForTranslations(input_api, output_api):
Don't embed translations directly in shared UI code. Instead, inject your
translation from the place using the shared code. For an example: see
<cr-dialog>#closeText (http://bit.ly/2eLEsqh).""")]
+
+
+def _CommonChecks(input_api, output_api):
+ results = []
+ results += _CheckForTranslations(input_api, output_api)
+ results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
dpapad 2016/12/22 00:59:13 Can you ensure that this does not create a problem
Dan Beam 2016/12/22 00:59:54 right, there are no crisper files in ui/webui/reso
+ return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698