Chromium Code Reviews| Index: ui/webui/resources/PRESUBMIT.py |
| diff --git a/ui/webui/resources/PRESUBMIT.py b/ui/webui/resources/PRESUBMIT.py |
| index 521ad5e6effce837372b926dba56439f9aab855b..60059c2e14eb371423c8099f1ec85870c43e1512 100644 |
| --- a/ui/webui/resources/PRESUBMIT.py |
| +++ b/ui/webui/resources/PRESUBMIT.py |
| @@ -30,11 +30,11 @@ def PostUploadHook(cl, change, output_api): |
| def CheckChangeOnUpload(input_api, output_api): |
| - return _CheckForTranslations(input_api, output_api) |
| + return _CommonChecks(input_api, output_api) |
| def CheckChangeOnCommit(input_api, output_api): |
| - return _CheckForTranslations(input_api, output_api) |
| + return _CommonChecks(input_api, output_api) |
| def _CheckForTranslations(input_api, output_api): |
| @@ -68,3 +68,10 @@ def _CheckForTranslations(input_api, output_api): |
| Don't embed translations directly in shared UI code. Instead, inject your |
| translation from the place using the shared code. For an example: see |
| <cr-dialog>#closeText (http://bit.ly/2eLEsqh).""")] |
| + |
| + |
| +def _CommonChecks(input_api, output_api): |
| + results = [] |
| + results += _CheckForTranslations(input_api, output_api) |
| + results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) |
|
dpapad
2016/12/22 00:59:13
Can you ensure that this does not create a problem
Dan Beam
2016/12/22 00:59:54
right, there are no crisper files in ui/webui/reso
|
| + return results |