Run clang-format on ui/webui/resources

Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find ui/webui/resources -type f -name '*.js' | xargs clang-format -i

R=dpapad@chromium.org, stevenjb@chromium.org
BUG=567770
NOPRESUBMIT=true  # existing deprecated JS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://chromium.googlesource.com/chromium/src/+/5f6807f5ad3db2215f1d25837118e112e1437665

[Dan Beam, 2016-12-22 00:12:45]

Description was changed from

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find -type f -name '*.js' | xargs clang-format -i -style=Chromium

R=dpapad@chromium.org
BUG=567770
==========

to

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find -type f -name '*.js' | xargs clang-format -i -style=Chromium

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-22 00:13:06]

see also: https://codereview.chromium.org/2592293002/

[Dan Beam, 2016-12-22 00:13:18]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 00:13:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 00:16:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 00:16:44]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Dan Beam, 2016-12-22 00:51:56]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 00:52:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-12-22 00:56:29]

Overall pretty cool. Caveats, git blame will point to you way more after this.
Also see question.

https://codereview.chromium.org/2597013002/diff/20001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/2597013002/diff/20001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/bubble.js:144: location ==
cr.ui.ArrowLocation.BOTTOM_END;
+dschuyler
This change is a surprise to me. Per the new JS styleguide this violates the
"rectangle rule", see
https://google.github.io/styleguide/jsguide.html#formatting-rectangle-rule.

[commit-bot: I haz the power, 2016-12-22 01:04:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 01:04:05]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2016-12-22 01:05:14]

On 2016/12/22 00:56:29, dpapad wrote:
> Overall pretty cool. Caveats, git blame will point to you way more after this.

git hyper-blame -i

https://codereview.chromium.org/2597013002/diff/20001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/2597013002/diff/20001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/bubble.js:144: location ==
cr.ui.ArrowLocation.BOTTOM_END;
On 2016/12/22 00:56:29, dpapad wrote:
> +dschuyler
> This change is a surprise to me. Per the new JS styleguide this violates the
> "rectangle rule", see
> https://google.github.io/styleguide/jsguide.html#formatting-rectangle-rule.

I think the style guide is intentionally ambiguous here, read 4.5*:
https://google.github.io/styleguide/jsguide.html#formatting-line-wrapping

"4+ spaces" is said repeatedly.  Meaning: the old code was valid. And the new
code is valid.  But the new code is more resilient to changes, as it's not based
on another line's indent as much.

[Dan Beam, 2016-12-22 01:05:46]

Description was changed from

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find -type f -name '*.js' | xargs clang-format -i -style=Chromium

R=dpapad@chromium.org
BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find -type f -name '*.js' | xargs clang-format -i -style=Chromium

R=dpapad@chromium.org
BUG=567770
NOPRESUBMIT=true  # existing deprecated JS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-12-22 01:10:49]

Touching files that haven't been touched before revealed some presubmit
errors/warnings, about __defineGetter__. Should those be addressed here?

Also should you vulcanize/crispify (or did you already do that, but no diff was
produced)?

[Dan Beam, 2016-12-22 01:18:10]

On 2016/12/22 01:10:49, dpapad wrote:
> Touching files that haven't been touched before revealed some presubmit
> errors/warnings, about __defineGetter__. Should those be addressed here?

not imo

> 
> Also should you vulcanize/crispify (or did you already do that, but no diff
was
> produced)?

just did

[Dan Beam, 2016-12-22 01:24:18]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[dschuyler, 2016-12-22 01:24:24]

dschuyler@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dschuyler, 2016-12-22 01:24:25]

https://codereview.chromium.org/2597013002/diff/20001/ui/webui/resources/js/c...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/2597013002/diff/20001/ui/webui/resources/js/c...
ui/webui/resources/js/cr/ui/bubble.js:144: location ==
cr.ui.ArrowLocation.BOTTOM_END;
On 2016/12/22 01:05:13, Dan Beam wrote:
> On 2016/12/22 00:56:29, dpapad wrote:
> > +dschuyler
> > This change is a surprise to me. Per the new JS styleguide this violates the
> > "rectangle rule", see
> > https://google.github.io/styleguide/jsguide.html#formatting-rectangle-rule.
> 
> I think the style guide is intentionally ambiguous here, read 4.5*:
> https://google.github.io/styleguide/jsguide.html#formatting-line-wrapping
> 
> "4+ spaces" is said repeatedly.  Meaning: the old code was valid. And the new
> code is valid.  

In my reading, both the new and old were valid prior to the newest style guide.
If I understand the guide correctly, the lines should read:

this.arrowAtRight_ = 
    location == cr.ui.ArrowLocation.TOP_END ||
        location == cr.ui.ArrowLocation.BOTTOM_END;

It looks like a fairly direct match to the example given in 4.5.6, which is:

currentEstimate =
    (currentEstimate + x / currentEstimate)
        / 2.0f;

> But the new code is more resilient to changes, as it's not based
> on another line's indent as much.

That's a big advantage imo.

[commit-bot: I haz the power, 2016-12-22 01:24:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-22 01:26:32]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 01:26:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-12-22 01:31:36]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2016-12-22 01:31:37]

kool. RS lgtm.

[dpapad, 2016-12-22 01:42:56]

LGTM

[commit-bot: I haz the power, 2016-12-22 01:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 01:44:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-12-22 02:05:54]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 02:06:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 02:08:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 02:08:48]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Dan Beam, 2016-12-22 02:54:06]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 02:54:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-22 03:01:33]

Patchset #7 (id:120001) has been deleted

[Dan Beam, 2016-12-22 03:17:24]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 03:17:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-22 03:35:31]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-12-22 03:35:48]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-12-22 03:35:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2597013002/#ps140001
(title: "preserve quotes for now")

[commit-bot: I haz the power, 2016-12-22 03:36:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-22 04:08:50]

Description was changed from

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find -type f -name '*.js' | xargs clang-format -i -style=Chromium

R=dpapad@chromium.org
BUG=567770
NOPRESUBMIT=true  # existing deprecated JS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find -type f -name '*.js' | xargs clang-format -i

R=dpapad@chromium.org
BUG=567770
NOPRESUBMIT=true  # existing deprecated JS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-12-22 04:09:03]

Description was changed from

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find -type f -name '*.js' | xargs clang-format -i

R=dpapad@chromium.org
BUG=567770
NOPRESUBMIT=true  # existing deprecated JS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find ui/webui/resources -type f -name '*.js' | xargs clang-format -i

R=dpapad@chromium.org
BUG=567770
NOPRESUBMIT=true  # existing deprecated JS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-12-22 04:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 04:39:25]

Failed to apply patch for
ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js:
While running git apply --index -p1;
  Created missing directory ui/webui/resources/cr_elements/cr_shared_menu.
  error: ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js: does
not exist in index

Patch:       ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
Index: ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
diff --git a/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
b/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
index
872b4b8e01d2a87f5eee8d2dd59bd228965c838f..413299b9a08e0345c7bf8fa2a600f56c01769c90
100644
--- a/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
+++ b/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
@@ -29,39 +29,23 @@ Polymer({
     openAnimationConfig: {
       type: Object,
       value: function() {
-        return [{
-          name: 'fade-in-animation',
-          timing: {
-            delay: 50,
-            duration: 200
+        return [
+          {name: 'fade-in-animation', timing: {delay: 50, duration: 200}}, {
+            name: 'paper-menu-grow-width-animation',
+            timing: {delay: 50, duration: 150, easing: SLIDE_CUBIC_BEZIER}
+          },
+          {
+            name: 'paper-menu-grow-height-animation',
+            timing: {delay: 100, duration: 275, easing: SLIDE_CUBIC_BEZIER}
           }
-        }, {
-          name: 'paper-menu-grow-width-animation',
-          timing: {
-            delay: 50,
-            duration: 150,
-            easing: SLIDE_CUBIC_BEZIER
-          }
-        }, {
-          name: 'paper-menu-grow-height-animation',
-          timing: {
-            delay: 100,
-            duration: 275,
-            easing: SLIDE_CUBIC_BEZIER
-          }
-        }];
+        ];
       }
     },
 
     closeAnimationConfig: {
       type: Object,
       value: function() {
-        return [{
-          name: 'fade-out-animation',
-          timing: {
-            duration: 150
-          }
-        }];
+        return [{name: 'fade-out-animation', timing: {duration: 150}}];
       }
     }
   },

[commit-bot: I haz the power, 2016-12-22 05:02:53]

Description was changed from

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find ui/webui/resources -type f -name '*.js' | xargs clang-format -i

R=dpapad@chromium.org
BUG=567770
NOPRESUBMIT=true  # existing deprecated JS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find ui/webui/resources -type f -name '*.js' | xargs clang-format -i

R=dpapad@chromium.org, stevenjb@chromium.org
BUG=567770
NOPRESUBMIT=true  # existing deprecated JS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5f6807f5ad3db2215f1d25837118e112e1437665
Cr-Commit-Position: refs/heads/master@{#440342}
==========

[commit-bot: I haz the power, 2016-12-22 05:02:54]

Patchset 8 (id:??) landed as
https://crrev.com/5f6807f5ad3db2215f1d25837118e112e1437665
Cr-Commit-Position: refs/heads/master@{#440342}

[Dan Beam, 2016-12-22 05:03:57]

Description was changed from

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find ui/webui/resources -type f -name '*.js' | xargs clang-format -i

R=dpapad@chromium.org, stevenjb@chromium.org
BUG=567770
NOPRESUBMIT=true  # existing deprecated JS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/5f6807f5ad3db2215f1d25837118e112e1437665
Cr-Commit-Position: refs/heads/master@{#440342}
==========

to

==========
Run clang-format on ui/webui/resources

This is in preparation of:
- turning down closure_linter
- turning on CheckPatchFormatted in the PRESUBMIT

This was done with:

  $ find ui/webui/resources -type f -name '*.js' | xargs clang-format -i

R=dpapad@chromium.org, stevenjb@chromium.org
BUG=567770
NOPRESUBMIT=true  # existing deprecated JS
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed:
https://chromium.googlesource.com/chromium/src/+/5f6807f5ad3db2215f1d25837118...
==========

[Dan Beam, 2016-12-22 05:03:58]

Committed patchset #8 (id:160001) manually as
5f6807f5ad3db2215f1d25837118e112e1437665.

[dschuyler, 2016-12-22 19:41:40]

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/cr_...
File ui/webui/resources/cr_elements/network/cr_network_list_item.js (right):

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/cr_...
ui/webui/resources/cr_elements/network/cr_network_list_item.js:104:
isStateTextConnected_() { return this.isListItem && this.isConnected_(); },
I think these unwrapped lines can make it hard to set breakpoints in the
debugger. e.g. in the old version a breakpoint could be set on line 105. In the
new version a breakpoint on line 104 will become an initialization breakpoint
iirc. 

Is there a way (and would it be desirable) to unwrap object inits like "foo =
{a:5, b:234};" and leave functions wrapped?

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/js/...
File ui/webui/resources/js/cr.js (right):

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/js/...
ui/webui/resources/js/cr.js:306: ctor.getInstance();
In some cases the format seems to favor doing a simple 4 space indent, without
doing this 'align to something in the line above' thing. In the ternary operator
case it seems to have gone with the 'align to something in the line above', is
that intended/desired?

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/js/...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/js/...
ui/webui/resources/js/cr/ui/bubble.js:101: this.innerHTML = '<div
class="bubble-content"></div>' +
Could the rectangle rule apply here? It seems more readable as it was (following
a rectangle rule).

[Dan Beam, 2016-12-22 19:42:30]

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/cr_...
File ui/webui/resources/cr_elements/network/cr_network_list_item.js (right):

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/cr_...
ui/webui/resources/cr_elements/network/cr_network_list_item.js:104:
isStateTextConnected_() { return this.isListItem && this.isConnected_(); },
On 2016/12/22 19:41:40, dschuyler wrote:
> I think these unwrapped lines can make it hard to set breakpoints in the
> debugger. e.g. in the old version a breakpoint could be set on line 105. In
the
> new version a breakpoint on line 104 will become an initialization breakpoint
> iirc. 
> 
> Is there a way (and would it be desirable) to unwrap object inits like "foo =
> {a:5, b:234};" and leave functions wrapped?

change ui/webui/resources/.clang-format

[Dan Beam, 2016-12-22 19:48:11]

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/cr_...
File ui/webui/resources/cr_elements/network/cr_network_list_item.js (right):

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/cr_...
ui/webui/resources/cr_elements/network/cr_network_list_item.js:104:
isStateTextConnected_() { return this.isListItem && this.isConnected_(); },
On 2016/12/22 19:42:30, Dan Beam wrote:
> On 2016/12/22 19:41:40, dschuyler wrote:
> > I think these unwrapped lines can make it hard to set breakpoints in the
> > debugger. e.g. in the old version a breakpoint could be set on line 105. In
> the
> > new version a breakpoint on line 104 will become an initialization
breakpoint
> > iirc. 
> > 
> > Is there a way (and would it be desirable) to unwrap object inits like "foo
=
> > {a:5, b:234};" and leave functions wrapped?
> 
> change ui/webui/resources/.clang-format

https://codereview.chromium.org/2603443002

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/js/...
File ui/webui/resources/js/cr.js (right):

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/js/...
ui/webui/resources/js/cr.js:306: ctor.getInstance();
On 2016/12/22 19:41:40, dschuyler wrote:
> In some cases the format seems to favor doing a simple 4 space indent, without
> doing this 'align to something in the line above' thing. In the ternary
operator
> case it seems to have gone with the 'align to something in the line above', is
> that intended/desired?

this is configurable to some extent

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/js/...
File ui/webui/resources/js/cr/ui/bubble.js (right):

https://codereview.chromium.org/2597013002/diff/160001/ui/webui/resources/js/...
ui/webui/resources/js/cr/ui/bubble.js:101: this.innerHTML = '<div
class="bubble-content"></div>' +
On 2016/12/22 19:41:40, dschuyler wrote:
> Could the rectangle rule apply here? It seems more readable as it was
(following
> a rectangle rule).

if this was made a multi-line string literal (i.e. `template`) it might be more
rectangular.  not sure exactly if configurable otherwise