Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Issue 2644843002: Rename GeneralizeRepresentation term to GeneralizeField in tests. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename GeneralizeRepresentation term to GeneralizeField in tests. BUG= Review-Url: https://codereview.chromium.org/2644843002 Cr-Commit-Position: refs/heads/master@{#42498} Committed: https://chromium.googlesource.com/v8/v8/+/1228306d30be5fdf388cf9f1d0db7fd4d7a3c497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -143 lines) Patch
M test/cctest/test-field-type-tracking.cc View 47 chunks +118 lines, -143 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-19 10:12:04 UTC) #5
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-19 11:39:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644843002/20001
3 years, 11 months ago (2017-01-19 12:02:50 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 12:04:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/1228306d30be5fdf388cf9f1d0db7fd4d7a...

Powered by Google App Engine
This is Rietveld 408576698