Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 2591063003: MIPS: Fix improper use of odd FP reg on mips32r6 (Closed)

Created:
3 years, 12 months ago by dusan.simicic
Modified:
3 years, 12 months ago
Reviewers:
ivica.bogosavljevic, v8-mips-ports, miran.karic
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix improper use of odd FP reg on mips32r6 Odd numbered floating-point register shouldn't be used as compare register on mips32r6 architecture. In case cpu switches to FRE mode, writes to odd numbered single-precision fp register will update upper part of even double-precision register, which will corrupt the even register. BUG= Review-Url: https://codereview.chromium.org/2591063003 Cr-Commit-Position: refs/heads/master@{#41916} Committed: https://chromium.googlesource.com/v8/v8/+/cc77bd8234a8aa2293c7a028571ae5e8d4d13134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/mips/assembler-mips.h View 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dusan.simicic
PTAL
3 years, 12 months ago (2016-12-21 12:54:13 UTC) #2
ivica.bogosavljevic
lgtm
3 years, 12 months ago (2016-12-21 13:52:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591063003/1
3 years, 12 months ago (2016-12-22 10:04:42 UTC) #10
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 10:06:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cc77bd8234a8aa2293c7a028571ae5e8d4d...

Powered by Google App Engine
This is Rietveld 408576698