Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js

Issue 2591043003: [Devtools] Setup network groupping to show bars for collapsed nodes (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
index 73b1dcc2d0a25371c0d0ae150fdc87715df6acf2..52719f12166207e574234329bd09237a5fec794d 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
@@ -308,10 +308,16 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
var rowOffset = this._rowHeight * i;
var node = nodes[i];
this._decorateRow(context, node, i, rowOffset - this._scrollTop);
- if (useTimingBars)
- this._drawTimingBars(context, node, rowOffset - this._scrollTop);
- else
- this._drawSimplifiedBars(context, node, rowOffset - this._scrollTop);
+ var drawNodes = [];
+ if (node.hasChildren() && !node.expanded)
+ drawNodes = /** @type {!Array<!Network.NetworkNode>} */ (node.flatChildren());
+ drawNodes.push(node);
+ for (var drawNode of drawNodes) {
+ if (useTimingBars)
+ this._drawTimingBars(context, drawNode, rowOffset - this._scrollTop);
+ else
+ this._drawSimplifiedBars(context, drawNode, rowOffset - this._scrollTop);
+ }
}
this._drawEventDividers(context);
context.restore();
@@ -434,7 +440,6 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
* @param {number} y
*/
_drawSimplifiedBars(context, node, y) {
- // TODO(allada) This should draw bars for groupped requests.
var request = node.request();
if (!request)
return;
@@ -553,7 +558,6 @@ Network.NetworkWaterfallColumn = class extends UI.VBox {
* @param {number} y
*/
_drawTimingBars(context, node, y) {
- // TODO(allada) This should draw bars for groupped requests.
var request = node.request();
if (!request)
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698