Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 2590883004: Put a TypeProvider on the TypeSystem implementations. (Closed)

Created:
4 years ago by Leaf
Modified:
3 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Put a TypeProvider on the TypeSystem implementations. Adding a TypeProvider instance to TypeSystem to avoid needing to thread it through the various APIs, and to avoid having to change the API every time a method which previously did not need to access the TypeSystem suddenly does. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/83fc4b6b4644f78103238e215e9e4cee3a1656cd

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -174 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/evaluation.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 7 chunks +11 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 11 chunks +7 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 2 38 chunks +75 lines, -99 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 4 chunks +8 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/static_type_analyzer_test.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/type_system_test.dart View 11 chunks +10 lines, -12 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 2 chunks +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
Leaf
4 years ago (2016-12-20 22:12:45 UTC) #2
Jennifer Messerly
LGTM!
3 years, 11 months ago (2017-01-04 01:51:05 UTC) #3
Leaf
3 years, 11 months ago (2017-01-09 10:40:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
83fc4b6b4644f78103238e215e9e4cee3a1656cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698