Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: pkg/analyzer/lib/src/task/strong/checker.dart

Issue 2590883004: Put a TypeProvider on the TypeSystem implementations. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | pkg/analyzer/lib/src/task/strong_mode.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/strong/checker.dart
diff --git a/pkg/analyzer/lib/src/task/strong/checker.dart b/pkg/analyzer/lib/src/task/strong/checker.dart
index 8beac155bfa11616cb2d138f54a7c3842162766f..a198649691298c4aed7bd92588b45e082ba59a4a 100644
--- a/pkg/analyzer/lib/src/task/strong/checker.dart
+++ b/pkg/analyzer/lib/src/task/strong/checker.dart
@@ -38,7 +38,7 @@ DartType getDefiniteType(
type is FunctionType &&
_hasStrictArrow(expression)) {
// Remove fuzzy arrow if possible.
- return typeSystem.functionTypeToConcreteType(typeProvider, type);
+ return typeSystem.functionTypeToConcreteType(type);
}
return type;
}
@@ -705,7 +705,7 @@ class CodeChecker extends RecursiveAstVisitor {
var rhsType = _getDefiniteType(expr.rightHandSide);
var lhsType = _getDefiniteType(expr.leftHandSide);
var returnType = rules.refineBinaryExpressionType(
- typeProvider, lhsType, op, rhsType, functionType.returnType);
+ lhsType, op, rhsType, functionType.returnType);
// Check the argument for an implicit cast.
_checkImplicitCast(expr.rightHandSide, paramTypes[0], from: rhsType);
@@ -901,8 +901,8 @@ class CodeChecker extends RecursiveAstVisitor {
var functionType = element.type;
var rhsType = typeProvider.intType;
var lhsType = _getDefiniteType(operand);
- var returnType = rules.refineBinaryExpressionType(typeProvider, lhsType,
- TokenType.PLUS, rhsType, functionType.returnType);
+ var returnType = rules.refineBinaryExpressionType(
+ lhsType, TokenType.PLUS, rhsType, functionType.returnType);
// Skip the argument check - `int` cannot be downcast.
//
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | pkg/analyzer/lib/src/task/strong_mode.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698