Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 2594873002: Make call methods definite. (Closed)

Created:
4 years ago by Leaf
Modified:
3 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make call methods definite. Makes objects with call methods be treated as definite functions. Fixes https://github.com/dart-lang/sdk/issues/28087 . BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/1ed1e1cb629e577bf9bf9af79b6c2a251556c880

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/type_system.dart View 2 chunks +12 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 2 3 chunks +13 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
Leaf
This patch set is dependent on https://codereview.chromium.org/2590883004/ .
4 years ago (2016-12-20 23:29:19 UTC) #2
Jennifer Messerly
LGTM!
3 years, 11 months ago (2017-01-04 01:51:44 UTC) #3
Leaf
3 years, 11 months ago (2017-01-09 12:02:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1ed1e1cb629e577bf9bf9af79b6c2a251556c880 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698