Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: pkg/analyzer/lib/src/generated/error_verifier.dart

Issue 2590883004: Put a TypeProvider on the TypeSystem implementations. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/constant.dart ('k') | pkg/analyzer/lib/src/generated/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/error_verifier.dart
diff --git a/pkg/analyzer/lib/src/generated/error_verifier.dart b/pkg/analyzer/lib/src/generated/error_verifier.dart
index dff34027eadeec61808fa934d7b87999dd391743..52aec1a2822bd41e69beb1ada56efaa5385111d5 100644
--- a/pkg/analyzer/lib/src/generated/error_verifier.dart
+++ b/pkg/analyzer/lib/src/generated/error_verifier.dart
@@ -6166,8 +6166,8 @@ class ErrorVerifier extends RecursiveAstVisitor<Object> {
DartType actualStaticType, DartType expectedStaticType) {
bool concrete = _options.strongMode && checker.isKnownFunction(expression);
if (concrete && actualStaticType is FunctionType) {
- actualStaticType = _typeSystem.functionTypeToConcreteType(
- _typeProvider, actualStaticType);
+ actualStaticType =
+ _typeSystem.functionTypeToConcreteType(actualStaticType);
// TODO(leafp): Move the Downcast functionality here.
}
return _typeSystem.isAssignableTo(actualStaticType, expectedStaticType);
@@ -6626,10 +6626,10 @@ class ErrorVerifier extends RecursiveAstVisitor<Object> {
FunctionType requiredMemberFT =
inheritanceManager.substituteTypeArgumentsInMemberFromInheritance(
requiredMemberType, memberName, enclosingType);
- foundConcreteFT = typeSystem.functionTypeToConcreteType(
- typeProvider, foundConcreteFT);
- requiredMemberFT = typeSystem.functionTypeToConcreteType(
- typeProvider, requiredMemberFT);
+ foundConcreteFT =
+ typeSystem.functionTypeToConcreteType(foundConcreteFT);
+ requiredMemberFT =
+ typeSystem.functionTypeToConcreteType(requiredMemberFT);
// Strong mode does override checking for types in CodeChecker, so
// we can skip it here. Doing it here leads to unnecessary duplicate
« no previous file with comments | « pkg/analyzer/lib/src/generated/constant.dart ('k') | pkg/analyzer/lib/src/generated/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698