Revert "third_party/protobuf: Update to HEAD (83d681ee2c)"

Revert "third_party/protobuf: Update to HEAD (83d681ee2c)"

This reverts commit 4fa2d9262fd91a4e613269f230cca34b95ca4af7.

Broken msan, see

https://build.chromium.org/p/chromium.memory.full/builders/Chromium%20Linux%20MSan%20Builder/builds/3718

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/228

Lots of

WARNING: MemorySanitizer: use-of-uninitialized-value

errors, i.e.

FAILED: gen/chrome/browser/profile_resetter/profile_reset_report.pb.h gen/chrome/browser/profile_resetter/profile_reset_report.pb.cc pyproto/chrome/browser/profile_resetter/profile_reset_report_pb2.py

python ../../tools/protoc_wrapper/protoc_wrapper.py profile_reset_report.proto --protoc ./protoc --proto-in-dir ../../chrome/browser/profile_resetter --cc-out-dir gen/chrome/browser/profile_resetter --py-out-dir pyproto/chrome/browser/profile_resetter

==13798==WARNING: MemorySanitizer: use-of-uninitialized-value

    #0 0x8b50eb  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

    #1 0x728c3a  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x728c3a)

    #2 0x6007b3  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6007b3)

    #3 0x4d56dc  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d56dc)

    #4 0x48e2a6  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

    #9 0x420a68  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x420a68)

  Uninitialized value was created by a heap allocation

    #0 0x48c8d2  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48c8d2)

    #1 0x6129be  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6129be)

    #2 0x5f7d54  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x5f7d54)

    #3 0x4d4657  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d4657)

    #4 0x48e2a6  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96  (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

Exiting

Protoc has returned non-zero status: 77 .

R=pkasting@chromium.org
BUG=

Committed: https://chromium.googlesource.com/chromium/src/+/4ab2a2f93ec3869acd606c7d5e6d7b361d7de381

[commit-bot: I haz the power, 2016-12-20 19:33:15]

Description was changed from

==========
Revert "third_party/protobuf: Update to HEAD (83d681ee2c)"

This reverts commit 4fa2d9262fd91a4e613269f230cca34b95ca4af7.

Broken msan, see

https://build.chromium.org/p/chromium.memory.full/builders/Chromium%20Linux%2...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

Lots of

WARNING: MemorySanitizer: use-of-uninitialized-value

errors, i.e.

FAILED: gen/chrome/browser/profile_resetter/profile_reset_report.pb.h
gen/chrome/browser/profile_resetter/profile_reset_report.pb.cc
pyproto/chrome/browser/profile_resetter/profile_reset_report_pb2.py

python ../../tools/protoc_wrapper/protoc_wrapper.py profile_reset_report.proto
--protoc ./protoc --proto-in-dir ../../chrome/browser/profile_resetter
--cc-out-dir gen/chrome/browser/profile_resetter --py-out-dir
pyproto/chrome/browser/profile_resetter

==13798==WARNING: MemorySanitizer: use-of-uninitialized-value

    #0 0x8b50eb 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

    #1 0x728c3a 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x728c3a)

    #2 0x6007b3 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6007b3)

    #3 0x4d56dc 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d56dc)

    #4 0x48e2a6 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

    #9 0x420a68 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x420a68)

  Uninitialized value was created by a heap allocation

    #0 0x48c8d2 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48c8d2)

    #1 0x6129be 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6129be)

    #2 0x5f7d54 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x5f7d54)

    #3 0x4d4657 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d4657)

    #4 0x48e2a6 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

SUMMARY: MemorySanitizer: use-of-uninitialized-value
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

Exiting

Protoc has returned non-zero status: 77 .

R=pkasting@chromium.org
BUG=
==========

to

==========
Revert "third_party/protobuf: Update to HEAD (83d681ee2c)"

This reverts commit 4fa2d9262fd91a4e613269f230cca34b95ca4af7.

Broken msan, see

https://build.chromium.org/p/chromium.memory.full/builders/Chromium%20Linux%2...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

Lots of

WARNING: MemorySanitizer: use-of-uninitialized-value

errors, i.e.

FAILED: gen/chrome/browser/profile_resetter/profile_reset_report.pb.h
gen/chrome/browser/profile_resetter/profile_reset_report.pb.cc
pyproto/chrome/browser/profile_resetter/profile_reset_report_pb2.py

python ../../tools/protoc_wrapper/protoc_wrapper.py profile_reset_report.proto
--protoc ./protoc --proto-in-dir ../../chrome/browser/profile_resetter
--cc-out-dir gen/chrome/browser/profile_resetter --py-out-dir
pyproto/chrome/browser/profile_resetter

==13798==WARNING: MemorySanitizer: use-of-uninitialized-value

    #0 0x8b50eb 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

    #1 0x728c3a 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x728c3a)

    #2 0x6007b3 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6007b3)

    #3 0x4d56dc 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d56dc)

    #4 0x48e2a6 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

    #9 0x420a68 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x420a68)

  Uninitialized value was created by a heap allocation

    #0 0x48c8d2 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48c8d2)

    #1 0x6129be 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6129be)

    #2 0x5f7d54 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x5f7d54)

    #3 0x4d4657 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d4657)

    #4 0x48e2a6 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

SUMMARY: MemorySanitizer: use-of-uninitialized-value
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

Exiting

Protoc has returned non-zero status: 77 .

R=pkasting@chromium.org
BUG=

Committed: https://crrev.com/4ab2a2f93ec3869acd606c7d5e6d7b361d7de381
Cr-Commit-Position: refs/heads/master@{#439867}
==========

[commit-bot: I haz the power, 2016-12-20 19:33:19]

Patchset 1 (id:??) landed as
https://crrev.com/4ab2a2f93ec3869acd606c7d5e6d7b361d7de381
Cr-Commit-Position: refs/heads/master@{#439867}

[jam, 2016-12-20 19:34:51]

Description was changed from

==========
Revert "third_party/protobuf: Update to HEAD (83d681ee2c)"

This reverts commit 4fa2d9262fd91a4e613269f230cca34b95ca4af7.

Broken msan, see

https://build.chromium.org/p/chromium.memory.full/builders/Chromium%20Linux%2...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

Lots of

WARNING: MemorySanitizer: use-of-uninitialized-value

errors, i.e.

FAILED: gen/chrome/browser/profile_resetter/profile_reset_report.pb.h
gen/chrome/browser/profile_resetter/profile_reset_report.pb.cc
pyproto/chrome/browser/profile_resetter/profile_reset_report_pb2.py

python ../../tools/protoc_wrapper/protoc_wrapper.py profile_reset_report.proto
--protoc ./protoc --proto-in-dir ../../chrome/browser/profile_resetter
--cc-out-dir gen/chrome/browser/profile_resetter --py-out-dir
pyproto/chrome/browser/profile_resetter

==13798==WARNING: MemorySanitizer: use-of-uninitialized-value

    #0 0x8b50eb 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

    #1 0x728c3a 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x728c3a)

    #2 0x6007b3 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6007b3)

    #3 0x4d56dc 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d56dc)

    #4 0x48e2a6 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

    #9 0x420a68 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x420a68)

  Uninitialized value was created by a heap allocation

    #0 0x48c8d2 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48c8d2)

    #1 0x6129be 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6129be)

    #2 0x5f7d54 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x5f7d54)

    #3 0x4d4657 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d4657)

    #4 0x48e2a6 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

SUMMARY: MemorySanitizer: use-of-uninitialized-value
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

Exiting

Protoc has returned non-zero status: 77 .

R=pkasting@chromium.org
BUG=

Committed: https://crrev.com/4ab2a2f93ec3869acd606c7d5e6d7b361d7de381
Cr-Commit-Position: refs/heads/master@{#439867}
==========

to

==========
Revert "third_party/protobuf: Update to HEAD (83d681ee2c)"

This reverts commit 4fa2d9262fd91a4e613269f230cca34b95ca4af7.

Broken msan, see

https://build.chromium.org/p/chromium.memory.full/builders/Chromium%20Linux%2...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

Lots of

WARNING: MemorySanitizer: use-of-uninitialized-value

errors, i.e.

FAILED: gen/chrome/browser/profile_resetter/profile_reset_report.pb.h
gen/chrome/browser/profile_resetter/profile_reset_report.pb.cc
pyproto/chrome/browser/profile_resetter/profile_reset_report_pb2.py

python ../../tools/protoc_wrapper/protoc_wrapper.py profile_reset_report.proto
--protoc ./protoc --proto-in-dir ../../chrome/browser/profile_resetter
--cc-out-dir gen/chrome/browser/profile_resetter --py-out-dir
pyproto/chrome/browser/profile_resetter

==13798==WARNING: MemorySanitizer: use-of-uninitialized-value

    #0 0x8b50eb 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

    #1 0x728c3a 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x728c3a)

    #2 0x6007b3 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6007b3)

    #3 0x4d56dc 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d56dc)

    #4 0x48e2a6 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

    #9 0x420a68 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x420a68)

  Uninitialized value was created by a heap allocation

    #0 0x48c8d2 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48c8d2)

    #1 0x6129be 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x6129be)

    #2 0x5f7d54 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x5f7d54)

    #3 0x4d4657 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4d4657)

    #4 0x48e2a6 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48e2a6)

    #5 0x4a8805 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x4a8805)

    #6 0x49d4c1 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x49d4c1)

    #7 0x48de96 
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x48de96)

    #8 0x7f9f29a7576c  (/lib/x86_64-linux-gnu/libc.so.6+0x2176c)

SUMMARY: MemorySanitizer: use-of-uninitialized-value
(/mnt/data/b/c/b/Chromium_Linux_MSan_Builder/src/out/Release/protoc+0x8b50eb)

Exiting

Protoc has returned non-zero status: 77 .

R=pkasting@chromium.org
BUG=

Committed:
https://chromium.googlesource.com/chromium/src/+/4ab2a2f93ec3869acd606c7d5e6d...
==========

[jam, 2016-12-20 19:34:55]

Committed patchset #1 (id:1) manually as
4ab2a2f93ec3869acd606c7d5e6d7b361d7de381.

[jbriance, 2016-12-20 22:26:27]

Sorry about that.

For the record, I've sent a PR to fix upstream's protobuf:
https://github.com/google/protobuf/pull/2523

[jbriance, 2016-12-23 09:43:08]

Follow-up: https://codereview.chromium.org/2599263002/