third_party/protobuf/src/google/protobuf/util/internal/json_escaping.cc - Issue 2590803003: Revert "third_party/protobuf: Update to HEAD (83d681ee2c)"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/src/google/protobuf/util/internal/json_escaping.cc

Issue 2590803003: Revert "third_party/protobuf: Update to HEAD (83d681ee2c)" (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/protobuf/src/google/protobuf/util/internal/field_mask_utility.cc ('k') | third_party/protobuf/src/google/protobuf/util/internal/json_objectwriter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/protobuf/src/google/protobuf/util/internal/json_escaping.cc

diff --git a/third_party/protobuf/src/google/protobuf/util/internal/json_escaping.cc b/third_party/protobuf/src/google/protobuf/util/internal/json_escaping.cc

index 06d2791bf261175ea78bb2c53e346c47a30ebbd0..24bd554ea3893ab5b5086ea60a2bfcf67dfb922d 100644

--- a/third_party/protobuf/src/google/protobuf/util/internal/json_escaping.cc

+++ b/third_party/protobuf/src/google/protobuf/util/internal/json_escaping.cc

@@ -255,7 +255,7 @@ StringPiece ToHex(uint16 cp, char* buffer) {

buffer[3] = kHex[cp & 0x0f];

cp >>= 4;

buffer[2] = kHex[cp & 0x0f];

- return StringPiece(buffer).substr(0, 6);

+ return StringPiece(buffer, 0, 6);

}

// Stores the 32-bit unicode code point as its hexadecimal digits in buffer