Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/protobuf/src/google/protobuf/util/json_util.h

Issue 2590803003: Revert "third_party/protobuf: Update to HEAD (83d681ee2c)" (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/protobuf/src/google/protobuf/util/json_util.h
diff --git a/third_party/protobuf/src/google/protobuf/util/json_util.h b/third_party/protobuf/src/google/protobuf/util/json_util.h
index 6d3cee52818f834ddd72e8c9576919b96f01f205..1718bfb528119fad916b0d934190ff7f3a89ef1a 100644
--- a/third_party/protobuf/src/google/protobuf/util/json_util.h
+++ b/third_party/protobuf/src/google/protobuf/util/json_util.h
@@ -33,7 +33,6 @@
#ifndef GOOGLE_PROTOBUF_UTIL_JSON_UTIL_H__
#define GOOGLE_PROTOBUF_UTIL_JSON_UTIL_H__
-#include <google/protobuf/message.h>
#include <google/protobuf/util/type_resolver.h>
#include <google/protobuf/stubs/bytestream.h>
@@ -45,14 +44,7 @@ class ZeroCopyOutputStream;
} // namespace io
namespace util {
-struct JsonParseOptions {
- // Whether to ignore unknown JSON fields during parsing
- bool ignore_unknown_fields;
-
- JsonParseOptions() : ignore_unknown_fields(false) {}
-};
-
-struct JsonPrintOptions {
+struct JsonOptions {
// Whether to add spaces, line breaks and indentation to make the JSON output
// easy to read.
bool add_whitespace;
@@ -62,57 +54,30 @@ struct JsonPrintOptions {
// behavior and print primitive fields regardless of their values.
bool always_print_primitive_fields;
- JsonPrintOptions() : add_whitespace(false),
- always_print_primitive_fields(false) {
+ JsonOptions() : add_whitespace(false),
+ always_print_primitive_fields(false) {
}
};
-// DEPRECATED. Use JsonPrintOptions instead.
-typedef JsonPrintOptions JsonOptions;
-
-// Converts from protobuf message to JSON. This is a simple wrapper of
-// BinaryToJsonString(). It will use the DescriptorPool of the passed-in
-// message to resolve Any types.
-LIBPROTOBUF_EXPORT util::Status MessageToJsonString(const Message& message,
- string* output,
- const JsonOptions& options);
-
-inline util::Status MessageToJsonString(const Message& message,
- string* output) {
- return MessageToJsonString(message, output, JsonOptions());
-}
-
-// Converts from JSON to protobuf message. This is a simple wrapper of
-// JsonStringToBinary(). It will use the DescriptorPool of the passed-in
-// message to resolve Any types.
-LIBPROTOBUF_EXPORT util::Status JsonStringToMessage(const string& input,
- Message* message,
- const JsonParseOptions& options);
-
-inline util::Status JsonStringToMessage(const string& input,
- Message* message) {
- return JsonStringToMessage(input, message, JsonParseOptions());
-}
-
// Converts protobuf binary data to JSON.
// The conversion will fail if:
// 1. TypeResolver fails to resolve a type.
// 2. input is not valid protobuf wire format, or conflicts with the type
// information returned by TypeResolver.
// Note that unknown fields will be discarded silently.
-LIBPROTOBUF_EXPORT util::Status BinaryToJsonStream(
+util::Status BinaryToJsonStream(
TypeResolver* resolver,
const string& type_url,
io::ZeroCopyInputStream* binary_input,
io::ZeroCopyOutputStream* json_output,
- const JsonPrintOptions& options);
+ const JsonOptions& options);
inline util::Status BinaryToJsonStream(
TypeResolver* resolver, const string& type_url,
io::ZeroCopyInputStream* binary_input,
io::ZeroCopyOutputStream* json_output) {
return BinaryToJsonStream(resolver, type_url, binary_input, json_output,
- JsonPrintOptions());
+ JsonOptions());
}
LIBPROTOBUF_EXPORT util::Status BinaryToJsonString(
@@ -120,14 +85,14 @@ LIBPROTOBUF_EXPORT util::Status BinaryToJsonString(
const string& type_url,
const string& binary_input,
string* json_output,
- const JsonPrintOptions& options);
+ const JsonOptions& options);
inline util::Status BinaryToJsonString(TypeResolver* resolver,
const string& type_url,
const string& binary_input,
string* json_output) {
return BinaryToJsonString(resolver, type_url, binary_input, json_output,
- JsonPrintOptions());
+ JsonOptions());
}
// Converts JSON data to protobuf binary format.
@@ -135,37 +100,18 @@ inline util::Status BinaryToJsonString(TypeResolver* resolver,
// 1. TypeResolver fails to resolve a type.
// 2. input is not valid JSON format, or conflicts with the type
// information returned by TypeResolver.
-LIBPROTOBUF_EXPORT util::Status JsonToBinaryStream(
+// 3. input has unknown fields.
+util::Status JsonToBinaryStream(
TypeResolver* resolver,
const string& type_url,
io::ZeroCopyInputStream* json_input,
- io::ZeroCopyOutputStream* binary_output,
- const JsonParseOptions& options);
-
-inline util::Status JsonToBinaryStream(
- TypeResolver* resolver,
- const string& type_url,
- io::ZeroCopyInputStream* json_input,
- io::ZeroCopyOutputStream* binary_output) {
- return JsonToBinaryStream(resolver, type_url, json_input, binary_output,
- JsonParseOptions());
-}
+ io::ZeroCopyOutputStream* binary_output);
LIBPROTOBUF_EXPORT util::Status JsonToBinaryString(
TypeResolver* resolver,
const string& type_url,
const string& json_input,
- string* binary_output,
- const JsonParseOptions& options);
-
-inline util::Status JsonToBinaryString(
- TypeResolver* resolver,
- const string& type_url,
- const string& json_input,
- string* binary_output) {
- return JsonToBinaryString(resolver, type_url, json_input, binary_output,
- JsonParseOptions());
-}
+ string* binary_output);
namespace internal {
// Internal helper class. Put in the header so we can write unit-tests for it.

Powered by Google App Engine
This is Rietveld 408576698