Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: third_party/protobuf/js/debug.js

Issue 2590803003: Revert "third_party/protobuf: Update to HEAD (83d681ee2c)" (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/protobuf/js/commonjs/export_testdeps.js ('k') | third_party/protobuf/js/debug_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/js/debug.js
diff --git a/third_party/protobuf/js/debug.js b/third_party/protobuf/js/debug.js
index 46b24853150af52ee70024f18beeb0680398fcf0..3701a0957ea05863dee4f547545cc9da9b8b529c 100644
--- a/third_party/protobuf/js/debug.js
+++ b/third_party/protobuf/js/debug.js
@@ -94,9 +94,8 @@ jspb.debug.dump_ = function(thing) {
var match = /^get([A-Z]\w*)/.exec(name);
if (match && name != 'getExtension' &&
name != 'getJsPbMessageId') {
- var has = 'has' + match[1];
- if (!thing[has] || thing[has]()) {
- var val = thing[name]();
+ var val = thing[name]();
+ if (val != null) {
object[jspb.debug.formatFieldName_(match[1])] = jspb.debug.dump_(val);
}
}
« no previous file with comments | « third_party/protobuf/js/commonjs/export_testdeps.js ('k') | third_party/protobuf/js/debug_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698