MD Downloads: gzip vulcanized resources via compress="gzip"

MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, change the API in WebUIDataSource from:

  void DisableI18nAndUseGzipForAllPaths()
  void ExcludePathFromGzip(const std::string& path)

to just:

  void UseGzip(const std::unordered_set<std::string>& excluded_paths)

because:

- $i18n{} support was added for gzipped resources[1], so the
  "DisableI18nAnd" no longer makes sense.

- "ForAllPaths" makes less sense as it requires a list of exclusions.

R=jam@chromium.org
BUG=653332
NOTRY=true  # see https://codereview.chromium.org/2597403002/

[1] https://codereview.chromium.org/2544683002/

Committed: https://crrev.com/d2f894f476b94600d3db7d25ff15d29819177c43
Cr-Commit-Position: refs/heads/master@{#440584}

[Dan Beam, 2016-12-20 23:20:44]

Description was changed from

==========
MD Downloads: gzip resources on disk

R=jam@chromium.org
BUG=653332
==========

to

==========
MD Downloads: gzip resources on disk

Reduces the amount of data stored and read from disk by 190419 bytes.

R=jam@chromium.org
BUG=653332
==========

[Dan Beam, 2016-12-20 23:28:18]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 23:29:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-20 23:41:17]

Description was changed from

==========
MD Downloads: gzip resources on disk

Reduces the amount of data stored and read from disk by 190419 bytes.

R=jam@chromium.org
BUG=653332
==========

to

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

R=jam@chromium.org
BUG=653332
==========

[Dan Beam, 2016-12-20 23:43:06]

Description was changed from

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

R=jam@chromium.org
BUG=653332
==========

to

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, drop the "DisableI18nAnd" from "UseGzipForAllPaths".
$i18n{} support was added for gzipped resources here:
https://codereview.chromium.org/2544683002/

R=jam@chromium.org
BUG=653332
==========

[commit-bot: I haz the power, 2016-12-21 00:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:54:57]

Dry run: This issue passed the CQ dry run.

[jam, 2016-12-21 21:18:31]

https://codereview.chromium.org/2590793004/diff/1/content/public/browser/web_...
File content/public/browser/web_ui_data_source.h (right):

https://codereview.chromium.org/2590793004/diff/1/content/public/browser/web_...
content/public/browser/web_ui_data_source.h:112: virtual void
ExcludePathFromGzip(const std::string& path) = 0;
do we really need two methods? can't UseGzipForAllPaths just take a vector for
exceptions? then there'd be no need to know what the right order for calling
these methods are etc

[Dan Beam, 2016-12-21 22:22:05]

https://codereview.chromium.org/2590793004/diff/1/content/public/browser/web_...
File content/public/browser/web_ui_data_source.h (right):

https://codereview.chromium.org/2590793004/diff/1/content/public/browser/web_...
content/public/browser/web_ui_data_source.h:112: virtual void
ExcludePathFromGzip(const std::string& path) = 0;
On 2016/12/21 21:18:31, jam wrote:
> do we really need two methods? can't UseGzipForAllPaths just take a vector for
> exceptions? then there'd be no need to know what the right order for calling
> these methods are etc

how does

virtual void UseGzip(const std::vector<std::string>& excluded_paths) = 0;

sound to you?

[Dan Beam, 2016-12-21 23:05:15]

Description was changed from

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, drop the "DisableI18nAnd" from "UseGzipForAllPaths".
$i18n{} support was added for gzipped resources here:
https://codereview.chromium.org/2544683002/

R=jam@chromium.org
BUG=653332
==========

to

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, change the API in WebUIDataSource from:

  void DisableI18nAndUseGzipForAllPaths()
  void ExcludePathFromGzip(const std::string& path)

to just:

  void UseGzip(cosnt std::unordered_set<std::string>& excluded_paths)

because:

- $i18n{} support was added for gzipped resources[1], so the
  "DisableI18nAnd" no longer makes sense.

- "ForAllPaths" makes less sense as it requires a list of exclusions.

R=jam@chromium.org
BUG=653332

[1] https://codereview.chromium.org/2544683002/
==========

[Dan Beam, 2016-12-21 23:05:53]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 23:06:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-21 23:06:35]

https://codereview.chromium.org/2590793004/diff/1/content/public/browser/web_...
File content/public/browser/web_ui_data_source.h (right):

https://codereview.chromium.org/2590793004/diff/1/content/public/browser/web_...
content/public/browser/web_ui_data_source.h:112: virtual void
ExcludePathFromGzip(const std::string& path) = 0;
On 2016/12/21 22:22:05, Dan Beam wrote:
> On 2016/12/21 21:18:31, jam wrote:
> > do we really need two methods? can't UseGzipForAllPaths just take a vector
for
> > exceptions? then there'd be no need to know what the right order for calling
> > these methods are etc
> 
> how does
> 
> virtual void UseGzip(const std::vector<std::string>& excluded_paths) = 0;
> 
> sound to you?

Done. (*except that I forgot excluded_paths_ was implemented as an
unordered_set, which seems fine for this)

[Dan Beam, 2016-12-22 00:52:27]

Description was changed from

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, change the API in WebUIDataSource from:

  void DisableI18nAndUseGzipForAllPaths()
  void ExcludePathFromGzip(const std::string& path)

to just:

  void UseGzip(cosnt std::unordered_set<std::string>& excluded_paths)

because:

- $i18n{} support was added for gzipped resources[1], so the
  "DisableI18nAnd" no longer makes sense.

- "ForAllPaths" makes less sense as it requires a list of exclusions.

R=jam@chromium.org
BUG=653332

[1] https://codereview.chromium.org/2544683002/
==========

to

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, change the API in WebUIDataSource from:

  void DisableI18nAndUseGzipForAllPaths()
  void ExcludePathFromGzip(const std::string& path)

to just:

  void UseGzip(const std::unordered_set<std::string>& excluded_paths)

because:

- $i18n{} support was added for gzipped resources[1], so the
  "DisableI18nAnd" no longer makes sense.

- "ForAllPaths" makes less sense as it requires a list of exclusions.

R=jam@chromium.org
BUG=653332

[1] https://codereview.chromium.org/2544683002/
==========

[commit-bot: I haz the power, 2016-12-22 02:02:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 02:02:47]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-12-22 20:40:23]

ping jam@

[jam, 2016-12-22 22:59:44]

lgtm

(sorry I missed your earlier message)

[Dan Beam, 2016-12-22 23:51:15]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-12-22 23:51:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-12-22 23:55:30]

On 2016/12/22 22:59:44, jam wrote:
> lgtm
> 
> (sorry I missed your earlier message)

all good, thanks for the review!

[commit-bot: I haz the power, 2016-12-23 02:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 02:03:43]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2016-12-23 02:12:55]

Description was changed from

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, change the API in WebUIDataSource from:

  void DisableI18nAndUseGzipForAllPaths()
  void ExcludePathFromGzip(const std::string& path)

to just:

  void UseGzip(const std::unordered_set<std::string>& excluded_paths)

because:

- $i18n{} support was added for gzipped resources[1], so the
  "DisableI18nAnd" no longer makes sense.

- "ForAllPaths" makes less sense as it requires a list of exclusions.

R=jam@chromium.org
BUG=653332

[1] https://codereview.chromium.org/2544683002/
==========

to

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, change the API in WebUIDataSource from:

  void DisableI18nAndUseGzipForAllPaths()
  void ExcludePathFromGzip(const std::string& path)

to just:

  void UseGzip(const std::unordered_set<std::string>& excluded_paths)

because:

- $i18n{} support was added for gzipped resources[1], so the
  "DisableI18nAnd" no longer makes sense.

- "ForAllPaths" makes less sense as it requires a list of exclusions.

R=jam@chromium.org
BUG=653332
NOTRY=true  # see https://codereview.chromium.org/2597403002/

[1] https://codereview.chromium.org/2544683002/
==========

[Dan Beam, 2016-12-23 02:13:38]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-12-23 02:13:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 02:18:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482459218160590,
"parent_rev": "cecb1e2a1e81c6f2863b42e12167b2b45578a277", "commit_rev":
"f8ae862b33e92fd9b4fc4e68be81575fbbb7d2f7"}

[commit-bot: I haz the power, 2016-12-23 02:18:51]

Description was changed from

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, change the API in WebUIDataSource from:

  void DisableI18nAndUseGzipForAllPaths()
  void ExcludePathFromGzip(const std::string& path)

to just:

  void UseGzip(const std::unordered_set<std::string>& excluded_paths)

because:

- $i18n{} support was added for gzipped resources[1], so the
  "DisableI18nAnd" no longer makes sense.

- "ForAllPaths" makes less sense as it requires a list of exclusions.

R=jam@chromium.org
BUG=653332
NOTRY=true  # see https://codereview.chromium.org/2597403002/

[1] https://codereview.chromium.org/2544683002/
==========

to

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, change the API in WebUIDataSource from:

  void DisableI18nAndUseGzipForAllPaths()
  void ExcludePathFromGzip(const std::string& path)

to just:

  void UseGzip(const std::unordered_set<std::string>& excluded_paths)

because:

- $i18n{} support was added for gzipped resources[1], so the
  "DisableI18nAnd" no longer makes sense.

- "ForAllPaths" makes less sense as it requires a list of exclusions.

R=jam@chromium.org
BUG=653332
NOTRY=true  # see https://codereview.chromium.org/2597403002/

[1] https://codereview.chromium.org/2544683002/

Review-Url: https://codereview.chromium.org/2590793004
==========

[commit-bot: I haz the power, 2016-12-23 02:18:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-23 02:20:58]

Description was changed from

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, change the API in WebUIDataSource from:

  void DisableI18nAndUseGzipForAllPaths()
  void ExcludePathFromGzip(const std::string& path)

to just:

  void UseGzip(const std::unordered_set<std::string>& excluded_paths)

because:

- $i18n{} support was added for gzipped resources[1], so the
  "DisableI18nAnd" no longer makes sense.

- "ForAllPaths" makes less sense as it requires a list of exclusions.

R=jam@chromium.org
BUG=653332
NOTRY=true  # see https://codereview.chromium.org/2597403002/

[1] https://codereview.chromium.org/2544683002/

Review-Url: https://codereview.chromium.org/2590793004
==========

to

==========
MD Downloads: gzip vulcanized resources via compress="gzip"

Reduces the amount of data stored and read from disk by 190419 bytes.

Also, change the API in WebUIDataSource from:

  void DisableI18nAndUseGzipForAllPaths()
  void ExcludePathFromGzip(const std::string& path)

to just:

  void UseGzip(const std::unordered_set<std::string>& excluded_paths)

because:

- $i18n{} support was added for gzipped resources[1], so the
  "DisableI18nAnd" no longer makes sense.

- "ForAllPaths" makes less sense as it requires a list of exclusions.

R=jam@chromium.org
BUG=653332
NOTRY=true  # see https://codereview.chromium.org/2597403002/

[1] https://codereview.chromium.org/2544683002/

Committed: https://crrev.com/d2f894f476b94600d3db7d25ff15d29819177c43
Cr-Commit-Position: refs/heads/master@{#440584}
==========

[commit-bot: I haz the power, 2016-12-23 02:21:00]

Patchset 2 (id:??) landed as
https://crrev.com/d2f894f476b94600d3db7d25ff15d29819177c43
Cr-Commit-Position: refs/heads/master@{#440584}