Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2592573002: MD Downloads: add first meaningful paint metrics to UMA (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
CC:
chromium-reviews, asanka, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: add first meaningful paint metrics to UMA Note: I played around with a bunch of random delayers. rIC seemed the best. R=tsergeant@chromium.org BUG=653332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/69e999cda573413b130ba7daad244afbdfb8acb8 Cr-Commit-Position: refs/heads/master@{#439924}

Patch Set 1 #

Total comments: 2

Patch Set 2 : asdf #

Patch Set 3 : -history #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -7 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/downloads.js View 1 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.js View 4 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (17 generated)
Dan Beam
4 years ago (2016-12-20 04:44:08 UTC) #2
tsergeant
lgtm I beat you to making those vulcanize changes, so if you want to rebase ...
4 years ago (2016-12-20 06:45:11 UTC) #7
Dan Beam
+asvitkine@ for histograms.xml
4 years ago (2016-12-20 06:52:23 UTC) #9
rkaplow
https://codereview.chromium.org/2592573002/diff/1/chrome/browser/resources/md_downloads/downloads.js File chrome/browser/resources/md_downloads/downloads.js (right): https://codereview.chromium.org/2592573002/diff/1/chrome/browser/resources/md_downloads/downloads.js#newcode9 chrome/browser/resources/md_downloads/downloads.js:9: 'Downloads.ResultsRenderedTime', extra s here - Download
4 years ago (2016-12-20 21:53:01 UTC) #11
Dan Beam
https://codereview.chromium.org/2592573002/diff/1/chrome/browser/resources/md_downloads/downloads.js File chrome/browser/resources/md_downloads/downloads.js (right): https://codereview.chromium.org/2592573002/diff/1/chrome/browser/resources/md_downloads/downloads.js#newcode9 chrome/browser/resources/md_downloads/downloads.js:9: 'Downloads.ResultsRenderedTime', On 2016/12/20 21:53:01, rkaplow wrote: > extra s ...
4 years ago (2016-12-20 22:02:47 UTC) #12
rkaplow
lgtm
4 years ago (2016-12-20 22:03:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592573002/20001
4 years ago (2016-12-20 22:05:19 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/126230) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-20 22:08:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592573002/60001
4 years ago (2016-12-20 22:18:48 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-20 23:34:28 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-20 23:37:17 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/69e999cda573413b130ba7daad244afbdfb8acb8
Cr-Commit-Position: refs/heads/master@{#439924}

Powered by Google App Engine
This is Rietveld 408576698