|
|
DescriptionMD History: gzip vulcanized resources via compress="gzip"
Saves 267950 bytes from being stored and read from disk.
R=tsergeant@chromium.org
BUG=653332
Committed: https://crrev.com/ed32c72638ed71f68b0abe42bfb46f073ae6ebe7
Cr-Commit-Position: refs/heads/master@{#440585}
Patch Set 1 #
Total comments: 3
Patch Set 2 : fixed it #Patch Set 3 : remove log #Patch Set 4 : merge #
Depends on Patchset: Messages
Total messages: 28 (19 generated)
Description was changed from ========== MD History: gzip resources via compress="gzip" R=tsergeant@chromium.org BUG=653332 ========== to ========== MD History: gzip resources via compress="gzip" Saves 267950 bytes from being stored and read from disk. R=tsergeant@chromium.org BUG=653332 ==========
Description was changed from ========== MD History: gzip resources via compress="gzip" Saves 267950 bytes from being stored and read from disk. R=tsergeant@chromium.org BUG=653332 ========== to ========== MD History: gzip vulcanized resources via compress="gzip" Saves 267950 bytes from being stored and read from disk. R=tsergeant@chromium.org BUG=653332 ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_... File chrome/browser/ui/webui/md_history_ui.cc (right): https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_... chrome/browser/ui/webui/md_history_ui.cc:153: source->ExcludePathFromGzip(""); Does this work with urls like /syncedTabs, which return the default resource?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_... File chrome/browser/ui/webui/md_history_ui.cc (right): https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_... chrome/browser/ui/webui/md_history_ui.cc:153: source->ExcludePathFromGzip(""); On 2016/12/21 02:05:45, tsergeant wrote: > Does this work with urls like /syncedTabs, which return the default resource? it does now!
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_... File chrome/browser/ui/webui/md_history_ui.cc (right): https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_... chrome/browser/ui/webui/md_history_ui.cc:153: source->ExcludePathFromGzip(""); On 2016/12/21 02:05:45, tsergeant wrote: > Does this work with urls like /syncedTabs, which return the default resource? The failing test (which loads the URL chrome://history?q=query) suggests that maybe it does not.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
wow, timing
lgtm
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsergeant@chromium.org Link to the patchset: https://codereview.chromium.org/2590383004/#ps60001 (title: "merge")
The CQ bit was unchecked by dbeam@chromium.org
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482460164309160, "parent_rev": "f8ae862b33e92fd9b4fc4e68be81575fbbb7d2f7", "commit_rev": "fa29d085d6467b78a4f3cc9d93500d72b3fd17a5"}
Message was sent while issue was closed.
Description was changed from ========== MD History: gzip vulcanized resources via compress="gzip" Saves 267950 bytes from being stored and read from disk. R=tsergeant@chromium.org BUG=653332 ========== to ========== MD History: gzip vulcanized resources via compress="gzip" Saves 267950 bytes from being stored and read from disk. R=tsergeant@chromium.org BUG=653332 Review-Url: https://codereview.chromium.org/2590383004 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== MD History: gzip vulcanized resources via compress="gzip" Saves 267950 bytes from being stored and read from disk. R=tsergeant@chromium.org BUG=653332 Review-Url: https://codereview.chromium.org/2590383004 ========== to ========== MD History: gzip vulcanized resources via compress="gzip" Saves 267950 bytes from being stored and read from disk. R=tsergeant@chromium.org BUG=653332 Committed: https://crrev.com/ed32c72638ed71f68b0abe42bfb46f073ae6ebe7 Cr-Commit-Position: refs/heads/master@{#440585} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/ed32c72638ed71f68b0abe42bfb46f073ae6ebe7 Cr-Commit-Position: refs/heads/master@{#440585} |