Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2590383004: MD History: gzip vulcanized resources via compress="gzip" (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, dbeam+watch-history_chromium.org, pam+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: gzip vulcanized resources via compress="gzip" Saves 267950 bytes from being stored and read from disk. R=tsergeant@chromium.org BUG=653332 Committed: https://crrev.com/ed32c72638ed71f68b0abe42bfb46f073ae6ebe7 Cr-Commit-Position: refs/heads/master@{#440585}

Patch Set 1 #

Total comments: 3

Patch Set 2 : fixed it #

Patch Set 3 : remove log #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -65 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/md_history_ui.cc View 1 2 2 chunks +54 lines, -60 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 28 (19 generated)
Dan Beam
4 years ago (2016-12-21 01:53:12 UTC) #3
tsergeant
https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_history_ui.cc File chrome/browser/ui/webui/md_history_ui.cc (right): https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_history_ui.cc#newcode153 chrome/browser/ui/webui/md_history_ui.cc:153: source->ExcludePathFromGzip(""); Does this work with urls like /syncedTabs, which ...
4 years ago (2016-12-21 02:05:45 UTC) #6
Dan Beam
https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_history_ui.cc File chrome/browser/ui/webui/md_history_ui.cc (right): https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_history_ui.cc#newcode153 chrome/browser/ui/webui/md_history_ui.cc:153: source->ExcludePathFromGzip(""); On 2016/12/21 02:05:45, tsergeant wrote: > Does this ...
4 years ago (2016-12-21 23:36:43 UTC) #9
tsergeant
https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_history_ui.cc File chrome/browser/ui/webui/md_history_ui.cc (right): https://codereview.chromium.org/2590383004/diff/1/chrome/browser/ui/webui/md_history_ui.cc#newcode153 chrome/browser/ui/webui/md_history_ui.cc:153: source->ExcludePathFromGzip(""); On 2016/12/21 02:05:45, tsergeant wrote: > Does this ...
4 years ago (2016-12-21 23:37:59 UTC) #11
tsergeant
wow, timing
4 years ago (2016-12-21 23:38:20 UTC) #13
tsergeant
lgtm
4 years ago (2016-12-21 23:58:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2590383004/60001
4 years ago (2016-12-23 02:29:34 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-23 02:33:20 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-23 02:35:58 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ed32c72638ed71f68b0abe42bfb46f073ae6ebe7
Cr-Commit-Position: refs/heads/master@{#440585}

Powered by Google App Engine
This is Rietveld 408576698