Add FacingMode to MediaStreamTrack.getSettings()

Add FacingMode to the values returned from MediaStreamTrack.getSettings.

Spec link:

https://w3c.github.io/mediacapture-main/getusermedia.html#dom-mediatracksettings-facingmode

Note on testing: Testing this properly at the JS API level requires the ability to insert fake devices with properties set by the test. That's too much for this CL.

Once https://codereview.chromium.org/2609863004/ lands, this can be manually tested on Chromebooks.

BUG=617142
Review-Url: https://codereview.chromium.org/2590193002
Cr-Commit-Position: refs/heads/master@{#445022}
Committed: https://chromium.googlesource.com/chromium/src/+/2d50a1b3b003d4a51a8f2ff4153d29a0273586eb

[hta - Chromium, 2017-01-03 14:20:28]

Patchset #2 (id:20001) has been deleted

[hta - Chromium, 2017-01-03 14:22:11]

Description was changed from

==========
Add FacingMode to MediaStreamTrack.getSettings()

BUG=617142
==========

to

==========
Note: Testing this properly at the JS API level requires the ability to insert
fake devices with properties set by the test. That's too much for this CL.

BUG=617142
==========

[hta - Chromium, 2017-01-03 14:22:11]

hta@chromium.org changed reviewers:
+ esprehn@chromium.org, tommi@chromium.org

[hta - Chromium, 2017-01-03 14:36:35]

Reviewer-ready. This is only one feature needed, but it was requested for
Android, and should work there. (Not tested.)

[tommi (sloooow) - chröme, 2017-01-04 08:56:16]

change lgtm but can you update the CL description? only the subject of the code
review explains what the cl does right now

[hta - Chromium, 2017-01-04 08:59:21]

Description was changed from

==========
Note: Testing this properly at the JS API level requires the ability to insert
fake devices with properties set by the test. That's too much for this CL.

BUG=617142
==========

to

==========
Add FacingMode to the values returned from MediaStreamTrack.getSettings.

Spec link:

https://w3c.github.io/mediacapture-main/getusermedia.html#dom-mediatracksetti...

Note: Testing this properly at the JS API level requires the ability to insert
fake devices with properties set by the test. That's too much for this CL.

BUG=617142
==========

[hta - Chromium, 2017-01-04 09:17:53]

On 2017/01/04 08:56:16, tommi (chrömium) wrote:
> change lgtm but can you update the CL description? only the subject of the
code
> review explains what the cl does right now

Description updated. Thanks!

[esprehn, 2017-01-04 09:21:38]

Let's get the tests first before adding features. What's the plan to have this
JS API tested?

[hta - Chromium, 2017-01-05 11:35:35]

On 2017/01/04 09:21:38, esprehn wrote:
> Let's get the tests first before adding features. What's the plan to have this
> JS API tested?

In order to have this API tested, I need fake devices; once I have fake devices,
I think the testing itself is going to be obvious.

I wrote up a proposal for fake devices here:

https://codereview.chromium.org/2612223002/

[hta - Chromium, 2017-01-17 11:01:52]

hta@chromium.org changed reviewers:
+ jochen@chromium.org

[hta - Chromium, 2017-01-17 11:03:22]

Added Jochen as reviewer since he's reviewing
https://codereview.chromium.org/2609863004/ which goes onto the backend of this.

Once that one lands, we should be able to test this without using fake devices,
so that's a new answer to esprehn's question.

(I'm still interested in having fake devices.)

[hta - Chromium, 2017-01-18 11:15:49]

Description was changed from

==========
Add FacingMode to the values returned from MediaStreamTrack.getSettings.

Spec link:

https://w3c.github.io/mediacapture-main/getusermedia.html#dom-mediatracksetti...

Note: Testing this properly at the JS API level requires the ability to insert
fake devices with properties set by the test. That's too much for this CL.

BUG=617142
==========

to

==========
Add FacingMode to the values returned from MediaStreamTrack.getSettings.

Spec link:

https://w3c.github.io/mediacapture-main/getusermedia.html#dom-mediatracksetti...

Note on testing: Testing this properly at the JS API level requires the ability
to insert fake devices with properties set by the test. That's too much for this
CL.

Once https://codereview.chromium.org/2609863004/ lands, this can be manually
tested on Chromebooks.

BUG=617142
==========

[jochen (gone - plz use gerrit), 2017-01-18 12:21:39]

I went ahead and approved https://codereview.chromium.org/2612223002/

with that landed, you can write a layout test that exercises the API, even
though the expectation will still be that it fails - but that's fine.

Can you add such a test?

Once we hook the rest of the system up, we'll then see how the test changes its
output

[hta - Chromium, 2017-01-18 19:31:20]

The CQ bit was checked by hta@chromium.org to run a CQ dry run

[hta - Chromium, 2017-01-18 19:31:39]

Does this seem like the right way to add a test that is "not all the way there
yet"?

[commit-bot: I haz the power, 2017-01-18 19:32:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:55:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:55:30]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-01-20 07:40:14]

lgtm

[hta - Chromium, 2017-01-20 07:42:28]

The CQ bit was checked by hta@chromium.org

[hta - Chromium, 2017-01-20 07:42:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2590193002/#ps60001
(title: "Layout test, with TODO")

[commit-bot: I haz the power, 2017-01-20 07:42:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 09:06:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484898148442480,
"parent_rev": "96139bc2addbe70ad373d57e3f45a9a0d23968dc", "commit_rev":
"2d50a1b3b003d4a51a8f2ff4153d29a0273586eb"}

[commit-bot: I haz the power, 2017-01-20 09:07:21]

Description was changed from

==========
Add FacingMode to the values returned from MediaStreamTrack.getSettings.

Spec link:

https://w3c.github.io/mediacapture-main/getusermedia.html#dom-mediatracksetti...

Note on testing: Testing this properly at the JS API level requires the ability
to insert fake devices with properties set by the test. That's too much for this
CL.

Once https://codereview.chromium.org/2609863004/ lands, this can be manually
tested on Chromebooks.

BUG=617142
==========

to

==========
Add FacingMode to the values returned from MediaStreamTrack.getSettings.

Spec link:

https://w3c.github.io/mediacapture-main/getusermedia.html#dom-mediatracksetti...

Note on testing: Testing this properly at the JS API level requires the ability
to insert fake devices with properties set by the test. That's too much for this
CL.

Once https://codereview.chromium.org/2609863004/ lands, this can be manually
tested on Chromebooks.

BUG=617142

Review-Url: https://codereview.chromium.org/2590193002
Cr-Commit-Position: refs/heads/master@{#445022}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d50a1b3b003d4a51a8f2ff4153d...
==========

[commit-bot: I haz the power, 2017-01-20 09:07:23]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2d50a1b3b003d4a51a8f2ff4153d...