Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp

Issue 2590193002: Add FacingMode to MediaStreamTrack.getSettings() (Closed)
Patch Set: Layout test, with TODO Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp b/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
index ea4244993f518b57f65cc60e627fe688e6cb260a..2b5595fd2b638752009e92fe6529ed0c6ed250a5 100644
--- a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
@@ -229,6 +229,25 @@ void MediaStreamTrack::getSettings(MediaTrackSettings& settings) {
settings.setHeight(platformSettings.height);
}
settings.setDeviceId(platformSettings.deviceId);
+ if (platformSettings.hasFacingMode()) {
+ switch (platformSettings.facingMode) {
+ case WebMediaStreamTrack::FacingMode::User:
+ settings.setFacingMode("user");
+ break;
+ case WebMediaStreamTrack::FacingMode::Environment:
+ settings.setFacingMode("environment");
+ break;
+ case WebMediaStreamTrack::FacingMode::Left:
+ settings.setFacingMode("left");
+ break;
+ case WebMediaStreamTrack::FacingMode::Right:
+ settings.setFacingMode("right");
+ break;
+ default:
+ // None, or unknown facing mode. Ignore.
+ break;
+ }
+ }
}
bool MediaStreamTrack::ended() const {

Powered by Google App Engine
This is Rietveld 408576698