Adds an API for inserting fake devices to internals

Adds an API for inserting fake devices to internals

This function is meant to be used like this in tests:

internals.addFakeDevice({kind=video}, {facingMode="user"})
.then( => getUserMedia({video: {facingMode: {exact: "user"}}})
.then(s => s.getSettings())
.then(settings => assert_equals(settings.facingMode, "user"))

STATUS: This CL version adds the API surface only.

BUG=678561
Review-Url: https://codereview.chromium.org/2612223002
Cr-Commit-Position: refs/heads/master@{#444376}
Committed: https://chromium.googlesource.com/chromium/src/+/d005cbf1f2a2d8aecd221922901e7e86fc5bea5c

[hta - Chromium, 2017-01-05 11:32:46]

Description was changed from

==========
Adds an API for inserting fake devices to internals

This function is meant to be used like this in tests:

internals.addFakeDevice({kind=video}, {facingMode="user"})
.then( => getUserMedia({video: {facingMode: {exact: "user"}}})
.then(s => s.getSettings())
.then(settings => assert_equals(settings.facingMode, "user"))

STATUS: This CL version adds the API surface only.

BUG=678561
==========

to

==========
Adds an API for inserting fake devices to internals

This function is meant to be used like this in tests:

internals.addFakeDevice({kind=video}, {facingMode="user"})
.then( => getUserMedia({video: {facingMode: {exact: "user"}}})
.then(s => s.getSettings())
.then(settings => assert_equals(settings.facingMode, "user"))

STATUS: This CL version adds the API surface only.

BUG=678561
==========

[hta - Chromium, 2017-01-05 11:32:46]

hta@chromium.org changed reviewers:
+ esprehn@chromium.org, foolip@chromium.org, guidou@chromium.org

[hta - Chromium, 2017-01-05 11:34:09]

This is pursuant to the discussion on testing in this CL:

https://codereview.chromium.org/2590193002/

It seemed simpler to show how testing can be done by coding an API than to
describe it in prose.

[Guido Urdaneta, 2017-01-10 11:21:25]

https://codereview.chromium.org/2612223002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/mediastream/testing/InternalsMediaStream.idl
(right):

https://codereview.chromium.org/2612223002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/mediastream/testing/InternalsMediaStream.idl:6:
[CallWith=ScriptState] Promise<void> addFakeDevice(
Would it make sense to make the return type void?

[Guido Urdaneta, 2017-01-10 11:23:45]

Never mind. I saw the use case and the promise give more flexibility for the
implementation.
lgtm

[jochen (gone - plz use gerrit), 2017-01-18 12:20:27]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-01-18 12:20:28]

lgtm

[hta - Chromium, 2017-01-18 12:50:49]

The CQ bit was checked by hta@chromium.org

[hta - Chromium, 2017-01-18 12:51:03]

The CQ bit was unchecked by hta@chromium.org

[commit-bot: I haz the power, 2017-01-18 12:51:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hta - Chromium, 2017-01-18 12:51:22]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2017-01-18 12:51:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 16:04:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484743882292210, "parent_rev":
"22d2602cc9c88683ee0a121bc66dccf57cc7ad3d", "commit_rev":
"d005cbf1f2a2d8aecd221922901e7e86fc5bea5c"}

[commit-bot: I haz the power, 2017-01-18 16:05:32]

Description was changed from

==========
Adds an API for inserting fake devices to internals

This function is meant to be used like this in tests:

internals.addFakeDevice({kind=video}, {facingMode="user"})
.then( => getUserMedia({video: {facingMode: {exact: "user"}}})
.then(s => s.getSettings())
.then(settings => assert_equals(settings.facingMode, "user"))

STATUS: This CL version adds the API surface only.

BUG=678561
==========

to

==========
Adds an API for inserting fake devices to internals

This function is meant to be used like this in tests:

internals.addFakeDevice({kind=video}, {facingMode="user"})
.then( => getUserMedia({video: {facingMode: {exact: "user"}}})
.then(s => s.getSettings())
.then(settings => assert_equals(settings.facingMode, "user"))

STATUS: This CL version adds the API surface only.

BUG=678561

Review-Url: https://codereview.chromium.org/2612223002
Cr-Commit-Position: refs/heads/master@{#444376}
Committed:
https://chromium.googlesource.com/chromium/src/+/d005cbf1f2a2d8aecd221922901e...
==========

[commit-bot: I haz the power, 2017-01-18 16:05:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d005cbf1f2a2d8aecd221922901e...