Upstream Chrome on iOS source code [11/11].

Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277eaf132dce4831
Committed: https://crrev.com/69edf1bf823ad0115305edafebfbec8c84a343bd
Cr-Commit-Position: refs/heads/master@{#439601}

[sdefresne, 2016-12-19 15:27:16]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 15:27:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-19 15:32:10]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2016-12-19 15:32:11]

Please take a look.

[rohitrao (ping after 24h), 2016-12-19 16:16:34]

lgtm!!!!

[sdefresne, 2016-12-19 16:19:18]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-12-19 16:19:22]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-12-19 16:19:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pink (ping after 24hrs), 2016-12-19 16:37:47]

pinkerton@chromium.org changed reviewers:
+ pinkerton@chromium.org

[pink (ping after 24hrs), 2016-12-19 16:37:47]

LGTM. Make it so.

[sdefresne, 2016-12-19 16:51:49]

sdefresne@chromium.org changed reviewers:
+ agrieve@chromium.org, markusheintz@chromium.org

[sdefresne, 2016-12-19 16:51:49]

agrieve/markusheintz: as discussed via chat, android_n5x_swarming_rel is flaking
and this CL is only affecting iOS where all bots are green. I'm landing manually
with "git cl land".

[blundell, 2016-12-19 16:54:27]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2016-12-19 16:54:28]

I regret that I have but one LGTM to give.

[commit-bot: I haz the power, 2016-12-19 16:58:50]

Description was changed from

==========
Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
==========

to

==========
Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Committed: https://crrev.com/1e23576749d95a02d22b2ff4277eaf132dce4831
Cr-Commit-Position: refs/heads/master@{#439492}
==========

[commit-bot: I haz the power, 2016-12-19 16:58:51]

Patchset 1 (id:??) landed as
https://crrev.com/1e23576749d95a02d22b2ff4277eaf132dce4831
Cr-Commit-Position: refs/heads/master@{#439492}

[stuartmorgan, 2016-12-19 16:59:02]

I wish I were still an OWNER so that my extreme LGTM would be more than just
symbolic!

[sdefresne, 2016-12-19 17:00:47]

Description was changed from

==========
Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Committed: https://crrev.com/1e23576749d95a02d22b2ff4277eaf132dce4831
Cr-Commit-Position: refs/heads/master@{#439492}
==========

to

==========
Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277e...
==========

[sdefresne, 2016-12-19 17:00:49]

Committed patchset #1 (id:1) manually as
1e23576749d95a02d22b2ff4277eaf132dce4831 (presubmit successful).

[sdefresne, 2016-12-19 17:22:16]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2589883002/ by sdefresne@chromium.org.

The reason for reverting is: Fail compilation on the waterfall..

[sdefresne, 2016-12-19 19:37:59]

Description was changed from

==========
Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277e...
==========

to

==========
Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277e...
==========

[sdefresne, 2016-12-19 19:38:30]

Re-opening in preparation of re-landing as we think the issue has been fixed.

[rohitrao (ping after 24h), 2016-12-19 19:40:43]

On 2016/12/19 19:38:30, sdefresne wrote:
> Re-opening in preparation of re-landing as we think the issue has been fixed.

The underlying issue was, in theory, that the bot had not compiled a xib file
since it was switched to use hermetic builds two weeks ago.  This left the bot
running two different versions of xcode, which confuses ibtool.

The bot appears to be in a better state now, so we'd like to try relanding the
same CL with no changes.

[sdefresne, 2016-12-19 19:43:03]

On 2016/12/19 19:40:43, rohitrao wrote:
> On 2016/12/19 19:38:30, sdefresne wrote:
> > Re-opening in preparation of re-landing as we think the issue has been
fixed.
> 
> The underlying issue was, in theory, that the bot had not compiled a xib file
> since it was switched to use hermetic builds two weeks ago.  This left the bot
> running two different versions of xcode, which confuses ibtool.
> 
> The bot appears to be in a better state now, so we'd like to try relanding the
> same CL with no changes.

Will wait for https://codereview.chromium.org/2587123002/ to land and the ios
bots to turn green before sending to the CQ so that we have confidence that
analyze steps rebuilds all the targets added in that CL.

[sdefresne, 2016-12-19 19:49:43]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 19:50:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-19 19:51:12]

The CQ bit was unchecked by sdefresne@chromium.org

[rohitrao (ping after 24h), 2016-12-19 21:42:04]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 21:42:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:49:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:49:28]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-12-19 22:46:29]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-12-19 22:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 22:53:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482187589751650, "parent_rev":
"45c0c6e33247e75148417008856f4dab1c99b41c", "commit_rev":
"51384b12b0a041208116cb5762a95eed1bd7a10c"}

[commit-bot: I haz the power, 2016-12-19 22:54:13]

Description was changed from

==========
Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277e...
==========

to

==========
Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277e...
Review-Url: https://codereview.chromium.org/2589843002
==========

[commit-bot: I haz the power, 2016-12-19 22:54:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-19 22:55:37]

Description was changed from

==========
Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277e...
Review-Url: https://codereview.chromium.org/2589843002
==========

to

==========
Upstream Chrome on iOS source code [11/11].

Upstream all BUILD.gn changes to enable compilation of the code
that has been upstreamed by the previous ten CLs and changes to
browser_state_keyed_service_factories.mm to use the new factory.

Update the default provider factory to use chromium provider (it
will be merged with ChromeBrowserProvider eventually).

BUG=653086
R=pinkerton@chromium.org, rohitrao@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277e...
Committed: https://crrev.com/69edf1bf823ad0115305edafebfbec8c84a343bd
Cr-Commit-Position: refs/heads/master@{#439601}
==========

[commit-bot: I haz the power, 2016-12-19 22:55:38]

Patchset 1 (id:??) landed as
https://crrev.com/69edf1bf823ad0115305edafebfbec8c84a343bd
Cr-Commit-Position: refs/heads/master@{#439601}