Build //ios:all and its dependencies on the iOS builders.

Build //ios:all and its dependencies on the iOS builders.

Build all dependencies of //ios:all on iOS builders. This includes
all the test targets (including the ones that are not yet run as
they first need to be enabled on FYI bots, and the main app that
is not a test target).

BUG=653086
Committed: https://crrev.com/cb279cab4502d332e78eca513e5a2e7dde9b324d
Cr-Commit-Position: refs/heads/master@{#439567}

[sdefresne, 2016-12-19 18:53:35]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org, rohitrao@chromium.org

[sdefresne, 2016-12-19 18:53:35]

Could you both please take a look? This should fix the analyze step with
https://chromium-review.googlesource.com/#/c/421182/.

[rohitrao (ping after 24h), 2016-12-19 18:56:04]

https://codereview.chromium.org/2587123002/diff/1/ios/build/bots/chromium.mac...
File ios/build/bots/chromium.mac/ios-simulator-cronet.json (right):

https://codereview.chromium.org/2587123002/diff/1/ios/build/bots/chromium.mac...
ios/build/bots/chromium.mac/ios-simulator-cronet.json:23:
"additional_compile_targets": [
Even for cronet?

[sdefresne, 2016-12-19 19:12:48]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-12-19 19:13:00]

This should be ready for review!

https://codereview.chromium.org/2587123002/diff/1/ios/build/bots/chromium.mac...
File ios/build/bots/chromium.mac/ios-simulator-cronet.json (right):

https://codereview.chromium.org/2587123002/diff/1/ios/build/bots/chromium.mac...
ios/build/bots/chromium.mac/ios-simulator-cronet.json:23:
"additional_compile_targets": [
On 2016/12/19 18:56:04, rohitrao wrote:
> Even for cronet?

Probably not (though ios:all is smart and exists for cronet too and only
contains what is needed on cronet, so it would probably have worked).

[commit-bot: I haz the power, 2016-12-19 19:13:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2016-12-19 19:13:56]

bot configs lgtm

[Dirk Pranke, 2016-12-19 19:14:52]

lgtm

[sdefresne, 2016-12-19 19:15:30]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-12-19 19:15:32]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-12-19 19:15:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-19 19:26:04]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-12-19 19:34:54]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-12-19 19:35:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:22:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482176094145780,
"parent_rev": "79a46d5348b590f5cf26b685fbc4445977223dcc", "commit_rev":
"f9a173b06d9216659728013db8ef12ebffcc23a6"}

[commit-bot: I haz the power, 2016-12-19 21:22:50]

Description was changed from

==========
Build //ios:all and its dependencies on the iOS builders.

Build all dependencies of //ios:all on iOS builders. This includes
all the test targets (including the ones that are not yet run as
they first need to be enabled on FYI bots, and the main app that
is not a test target).

BUG=653086
==========

to

==========
Build //ios:all and its dependencies on the iOS builders.

Build all dependencies of //ios:all on iOS builders. This includes
all the test targets (including the ones that are not yet run as
they first need to be enabled on FYI bots, and the main app that
is not a test target).

BUG=653086

Review-Url: https://codereview.chromium.org/2587123002
==========

[commit-bot: I haz the power, 2016-12-19 21:22:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-19 21:26:43]

Description was changed from

==========
Build //ios:all and its dependencies on the iOS builders.

Build all dependencies of //ios:all on iOS builders. This includes
all the test targets (including the ones that are not yet run as
they first need to be enabled on FYI bots, and the main app that
is not a test target).

BUG=653086

Review-Url: https://codereview.chromium.org/2587123002
==========

to

==========
Build //ios:all and its dependencies on the iOS builders.

Build all dependencies of //ios:all on iOS builders. This includes
all the test targets (including the ones that are not yet run as
they first need to be enabled on FYI bots, and the main app that
is not a test target).

BUG=653086

Committed: https://crrev.com/cb279cab4502d332e78eca513e5a2e7dde9b324d
Cr-Commit-Position: refs/heads/master@{#439567}
==========

[commit-bot: I haz the power, 2016-12-19 21:26:44]

Patchset 2 (id:??) landed as
https://crrev.com/cb279cab4502d332e78eca513e5a2e7dde9b324d
Cr-Commit-Position: refs/heads/master@{#439567}