Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 2589883002: Revert of Upstream Chrome on iOS source code [11/11]. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, msramek+watch_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, mlamouri+watch-geolocation_chromium.org, rouslan+autofill_chromium.org, tfarina, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), browser-components-watch_chromium.org, cbentzel+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, Michael van Ouwerkerk, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, markusheintz_, stkhapugin, gcasto+watchlist_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Upstream Chrome on iOS source code [11/11]. (patchset #1 id:1 of https://codereview.chromium.org/2589843002/ ) Reason for revert: Fail compilation on the waterfall. Original issue's description: > Upstream Chrome on iOS source code [11/11]. > > Upstream all BUILD.gn changes to enable compilation of the code > that has been upstreamed by the previous ten CLs and changes to > browser_state_keyed_service_factories.mm to use the new factory. > > Update the default provider factory to use chromium provider (it > will be merged with ChromeBrowserProvider eventually). > > BUG=653086 > R=pinkerton@chromium.org, rohitrao@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/1e23576749d95a02d22b2ff4277eaf132dce4831 TBR=rohitrao@chromium.org,pinkerton@chromium.org,agrieve@chromium.org,markusheintz@chromium.org,blundell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653086 Committed: https://crrev.com/975bfd6db8378e8a052348145a5e3ba1286bc855 Cr-Commit-Position: refs/heads/master@{#439493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6359 lines) Patch
M ios/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/app/BUILD.gn View 3 chunks +0 lines, -309 lines 0 comments Download
M ios/chrome/app/application_delegate/BUILD.gn View 1 chunk +0 lines, -124 lines 0 comments Download
M ios/chrome/app/safe_mode/BUILD.gn View 1 chunk +0 lines, -59 lines 0 comments Download
D ios/chrome/app/spotlight/BUILD.gn View 1 chunk +0 lines, -70 lines 0 comments Download
D ios/chrome/app/startup/BUILD.gn View 1 chunk +0 lines, -41 lines 0 comments Download
D ios/chrome/app/steps/BUILD.gn View 1 chunk +0 lines, -36 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 3 chunks +0 lines, -71 lines 0 comments Download
M ios/chrome/browser/autofill/BUILD.gn View 1 chunk +0 lines, -89 lines 0 comments Download
M ios/chrome/browser/browser_state/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/browsing_data/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
D ios/chrome/browser/context_menu/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
M ios/chrome/browser/crash_report/BUILD.gn View 1 chunk +0 lines, -49 lines 0 comments Download
M ios/chrome/browser/device_sharing/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
M ios/chrome/browser/geolocation/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
M ios/chrome/browser/metrics/BUILD.gn View 1 chunk +0 lines, -77 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/BUILD.gn View 1 chunk +0 lines, -51 lines 0 comments Download
M ios/chrome/browser/net/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
M ios/chrome/browser/passwords/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
M ios/chrome/browser/payments/BUILD.gn View 1 chunk +0 lines, -74 lines 0 comments Download
D ios/chrome/browser/payments/cells/BUILD.gn View 1 chunk +0 lines, -43 lines 0 comments Download
M ios/chrome/browser/sessions/BUILD.gn View 1 chunk +0 lines, -73 lines 0 comments Download
M ios/chrome/browser/signin/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M ios/chrome/browser/snapshots/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D ios/chrome/browser/tabs/BUILD.gn View 1 chunk +0 lines, -144 lines 0 comments Download
D ios/chrome/browser/test/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
M ios/chrome/browser/translate/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
M ios/chrome/browser/ui/BUILD.gn View 2 chunks +0 lines, -292 lines 0 comments Download
D ios/chrome/browser/ui/actions/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M ios/chrome/browser/ui/activity_services/BUILD.gn View 1 chunk +0 lines, -77 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D ios/chrome/browser/ui/animators/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
M ios/chrome/browser/ui/authentication/BUILD.gn View 1 chunk +0 lines, -123 lines 0 comments Download
M ios/chrome/browser/ui/autofill/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D ios/chrome/browser/ui/autofill/cells/BUILD.gn View 1 chunk +0 lines, -50 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/BUILD.gn View 1 chunk +0 lines, -177 lines 0 comments Download
D ios/chrome/browser/ui/bookmarks/bars/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D ios/chrome/browser/ui/bookmarks/cells/BUILD.gn View 1 chunk +0 lines, -45 lines 0 comments Download
D ios/chrome/browser/ui/collection_view/BUILD.gn View 1 chunk +0 lines, -54 lines 0 comments Download
D ios/chrome/browser/ui/collection_view/cells/BUILD.gn View 1 chunk +0 lines, -72 lines 0 comments Download
D ios/chrome/browser/ui/colors/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/BUILD.gn View 1 chunk +0 lines, -110 lines 0 comments Download
D ios/chrome/browser/ui/contextual_search/protos/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/dialogs/BUILD.gn View 1 chunk +0 lines, -73 lines 0 comments Download
M ios/chrome/browser/ui/downloads/BUILD.gn View 1 chunk +0 lines, -46 lines 0 comments Download
M ios/chrome/browser/ui/elements/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D ios/chrome/browser/ui/fancy_ui/BUILD.gn View 1 chunk +0 lines, -36 lines 0 comments Download
M ios/chrome/browser/ui/find_bar/BUILD.gn View 1 chunk +0 lines, -46 lines 0 comments Download
M ios/chrome/browser/ui/first_run/BUILD.gn View 1 chunk +0 lines, -100 lines 0 comments Download
D ios/chrome/browser/ui/history/BUILD.gn View 1 chunk +0 lines, -176 lines 0 comments Download
M ios/chrome/browser/ui/icons/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
M ios/chrome/browser/ui/infobars/BUILD.gn View 1 chunk +0 lines, -58 lines 0 comments Download
D ios/chrome/browser/ui/main/BUILD.gn View 1 chunk +0 lines, -53 lines 0 comments Download
D ios/chrome/browser/ui/material_components/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D ios/chrome/browser/ui/no_tabs/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
M ios/chrome/browser/ui/ntp/BUILD.gn View 1 chunk +0 lines, -176 lines 0 comments Download
D ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn View 1 chunk +0 lines, -92 lines 0 comments Download
D ios/chrome/browser/ui/ntp/recent_tabs/views/BUILD.gn View 1 chunk +0 lines, -52 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/BUILD.gn View 1 chunk +0 lines, -106 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
M ios/chrome/browser/ui/popup_menu/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D ios/chrome/browser/ui/presenters/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D ios/chrome/browser/ui/print/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D ios/chrome/browser/ui/promos/BUILD.gn View 1 chunk +0 lines, -49 lines 0 comments Download
M ios/chrome/browser/ui/qr_scanner/BUILD.gn View 1 chunk +0 lines, -64 lines 0 comments Download
D ios/chrome/browser/ui/reader_mode/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/BUILD.gn View 1 chunk +0 lines, -104 lines 0 comments Download
D ios/chrome/browser/ui/sad_tab/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
M ios/chrome/browser/ui/settings/BUILD.gn View 1 chunk +0 lines, -357 lines 0 comments Download
D ios/chrome/browser/ui/settings/cells/BUILD.gn View 1 chunk +0 lines, -87 lines 0 comments Download
D ios/chrome/browser/ui/settings/utils/BUILD.gn View 1 chunk +0 lines, -57 lines 0 comments Download
M ios/chrome/browser/ui/side_swipe/BUILD.gn View 1 chunk +0 lines, -54 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/BUILD.gn View 1 chunk +0 lines, -116 lines 0 comments Download
D ios/chrome/browser/ui/static_content/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D ios/chrome/browser/ui/sync/BUILD.gn View 1 chunk +0 lines, -61 lines 0 comments Download
D ios/chrome/browser/ui/tab/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D ios/chrome/browser/ui/tab_grid/BUILD.gn View 1 chunk +0 lines, -41 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/BUILD.gn View 1 chunk +0 lines, -151 lines 0 comments Download
M ios/chrome/browser/ui/tabs/BUILD.gn View 1 chunk +0 lines, -72 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/BUILD.gn View 1 chunk +0 lines, -184 lines 0 comments Download
D ios/chrome/browser/ui/tools/BUILD.gn View 1 chunk +0 lines, -35 lines 0 comments Download
D ios/chrome/browser/ui/tools_menu/BUILD.gn View 1 chunk +0 lines, -75 lines 0 comments Download
D ios/chrome/browser/ui/util/BUILD.gn View 1 chunk +0 lines, -59 lines 0 comments Download
D ios/chrome/browser/ui/web_contents/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
M ios/chrome/browser/ui/webui/BUILD.gn View 1 chunk +0 lines, -52 lines 0 comments Download
M ios/chrome/browser/web/BUILD.gn View 1 chunk +0 lines, -167 lines 0 comments Download
M ios/chrome/test/BUILD.gn View 2 chunks +2 lines, -65 lines 0 comments Download
D ios/chrome/test/app/BUILD.gn View 1 chunk +0 lines, -80 lines 0 comments Download
M ios/chrome/test/base/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M ios/chrome/test/earl_grey/BUILD.gn View 1 chunk +3 lines, -196 lines 0 comments Download
D ios/chrome/test/earl_grey/chrome_ios_eg_test.gni View 1 chunk +0 lines, -141 lines 0 comments Download
D ios/chrome/test/ocmock/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
M ios/public/provider/chrome/browser/build_config.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
sdefresne
Created Revert of Upstream Chrome on iOS source code [11/11].
4 years ago (2016-12-19 17:22:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2589883002/1
4 years ago (2016-12-19 17:22:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 17:27:05 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-19 17:29:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/975bfd6db8378e8a052348145a5e3ba1286bc855
Cr-Commit-Position: refs/heads/master@{#439493}

Powered by Google App Engine
This is Rietveld 408576698