Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2585193002: Files App: Add metrics for background performance. (Closed)

Created:
4 years ago by oka
Modified:
4 years ago
Reviewers:
fukino, jwd
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, asvitkine+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files App: Add metrics for background performance. FileBrowser.Load.BackgroundScript: Time to initialize backend script to wait for events. FileBrowser.Load.BackgroundLaunch: Time from onLaunched event is called to the window is created. FileBrowser.Load.BackgroundRestart: Time to create a window on restart. BUG=675536 TEST=manually confirmed on Linux that sane values are exported in chrome://histograms CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cf87bb1cf39b26f7127ba4cee4147c8d52966fd9 Cr-Commit-Position: refs/heads/master@{#439755}

Patch Set 1 #

Patch Set 2 : Move startInterval below an if statement. #

Patch Set 3 : Update histograms.xml. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/background.js View 1 4 chunks +9 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/background/js/background_scripts.js View 1 chunk +1 line, -0 lines 0 comments Download
A ui/file_manager/file_manager/background/js/metrics_start.js View 1 chunk +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
oka
PTAL. jwd@ for histograms.xml.
4 years ago (2016-12-19 08:45:47 UTC) #5
fukino
file_manger lgtm.
4 years ago (2016-12-19 08:56:02 UTC) #7
jwd
lgtm
4 years ago (2016-12-19 16:15:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585193002/40001
4 years ago (2016-12-20 04:32:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/353080)
4 years ago (2016-12-20 06:39:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585193002/40001
4 years ago (2016-12-20 06:45:28 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-20 09:07:31 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-20 09:10:07 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cf87bb1cf39b26f7127ba4cee4147c8d52966fd9
Cr-Commit-Position: refs/heads/master@{#439755}

Powered by Google App Engine
This is Rietveld 408576698