Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2589333005:
Verify that ExtendableMessageEvent's message ports reside on the same heap (Closed)
|
Created:
4 years ago by sof Modified:
4 years ago Reviewers:
haraken CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionVerify that ExtendableMessageEvent's message ports reside on the same heap
To potentially help diagnose a GC crash (see associated bug), verify
that ExtendableMessageEvent's MessagePortArray and MessagePorts belong
to the same thread heap as the event object.
R=haraken
BUG=655926
Committed: https://crrev.com/137ed1ac9cbb2dc5f84f3af169ae0b03b1a2361b
Cr-Commit-Position: refs/heads/master@{#440390}
Patch Set 1 #Patch Set 2 : fix same-thread ports verification #Patch Set 3 : address test failure. #
Depends on Patchset: Messages
Total messages: 25 (19 generated)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
sigbjornf@opera.com changed reviewers: + haraken@chromium.org
fyi - i haven't looked into the failures yet, but the same-thread checks are picking up on something. I'm assuming it's a bug on my part for the time being.
LGTM
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/21 22:29:41, sof wrote: > fyi - i haven't looked into the failures yet, but the same-thread checks are > picking up on something. I'm assuming it's a bug on my part for the time being. MessagePortArray* vs MessagePortArray& confusion cleared up; should be ready now.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Verify that ExtendableMessageEvent's message ports reside on the same heap To potentially help diagnose a GC crash (see associated bug), verify that ExtendableMessageEvent's MessagePortArray and MessagePorts belong to the same thread heap as the event object. R= BUG=655926 ========== to ========== Verify that ExtendableMessageEvent's message ports reside on the same heap To potentially help diagnose a GC crash (see associated bug), verify that ExtendableMessageEvent's MessagePortArray and MessagePorts belong to the same thread heap as the event object. R=haraken BUG=655926 ==========
The CQ bit was checked by sigbjornf@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2589333005/#ps40001 (title: "address test failure.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482408772476040,
"parent_rev": "fe6b9b58ec9390050092264385ab338d34ab03ad", "commit_rev":
"229361aee3225674e106995a0a636f4d52ac3e0d"}
Message was sent while issue was closed.
Description was changed from ========== Verify that ExtendableMessageEvent's message ports reside on the same heap To potentially help diagnose a GC crash (see associated bug), verify that ExtendableMessageEvent's MessagePortArray and MessagePorts belong to the same thread heap as the event object. R=haraken BUG=655926 ========== to ========== Verify that ExtendableMessageEvent's message ports reside on the same heap To potentially help diagnose a GC crash (see associated bug), verify that ExtendableMessageEvent's MessagePortArray and MessagePorts belong to the same thread heap as the event object. R=haraken BUG=655926 Review-Url: https://codereview.chromium.org/2589333005 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Verify that ExtendableMessageEvent's message ports reside on the same heap To potentially help diagnose a GC crash (see associated bug), verify that ExtendableMessageEvent's MessagePortArray and MessagePorts belong to the same thread heap as the event object. R=haraken BUG=655926 Review-Url: https://codereview.chromium.org/2589333005 ========== to ========== Verify that ExtendableMessageEvent's message ports reside on the same heap To potentially help diagnose a GC crash (see associated bug), verify that ExtendableMessageEvent's MessagePortArray and MessagePorts belong to the same thread heap as the event object. R=haraken BUG=655926 Committed: https://crrev.com/137ed1ac9cbb2dc5f84f3af169ae0b03b1a2361b Cr-Commit-Position: refs/heads/master@{#440390} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/137ed1ac9cbb2dc5f84f3af169ae0b03b1a2361b Cr-Commit-Position: refs/heads/master@{#440390} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
