third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h - Issue 2589333005: Verify that ExtendableMessageEvent's message ports reside on the same heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h

Issue 2589333005: Verify that ExtendableMessageEvent's message ports reside on the same heap (Closed)

Patch Set: address test failure. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h b/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h

index a3a05a1841fea0d07f13e8bdef4c835ce7163ae6..1086077e6b0b320612ba559aacc774da8a2ecb41 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h

@@ -71,7 +71,8 @@ class MODULES_EXPORT ExtendableMessageEvent final : public ExtendableEvent {

Member<ServiceWorkerClient> m_sourceAsClient;

Member<ServiceWorker> m_sourceAsServiceWorker;

Member<MessagePort> m_sourceAsMessagePort;

- Member<MessagePortArray> m_ports;

+ // TODO(sof): remove once crbug.com/655926 has been addressed.

+ SameThreadCheckedMember<MessagePortArray> m_ports;

};

} // namespace blink

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp » ('j') | no next file with comments »