Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2599533002: Introduce ThreadState::isOnThreadHeap() helper predicate. (Closed)

Created:
4 years ago by sof
Modified:
4 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ThreadState::isOnThreadHeap() helper predicate. Simple helper to make testing for on-thread-heap conditions easier. R= BUG= Committed: https://crrev.com/af3e39a55f2fe860fb1a6b679343763326cabb61 Cr-Commit-Position: refs/heads/master@{#440370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M third_party/WebKit/Source/platform/heap/Member.h View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years ago (2016-12-22 07:12:02 UTC) #2
haraken
LGTM
4 years ago (2016-12-22 07:25:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2599533002/1
4 years ago (2016-12-22 07:31:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 09:40:26 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-22 09:42:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af3e39a55f2fe860fb1a6b679343763326cabb61
Cr-Commit-Position: refs/heads/master@{#440370}

Powered by Google App Engine
This is Rietveld 408576698