[Sensors] Reland: Align sensor reading updates and 'onchange' notification with rAF.

[Sensors] Reland: Align sensor reading updates and 'onchange' notification with rAF.

For all sensors new reading values are read and 'onchange' notfication is send from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.

Before this change a timers were used and this could unnecessarily drain CPU and battery.

BUG=668052
BUG=606766
Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}

patch from issue 2551223003 at patchset 140001 (http://crrev.com/2551223003#ps140001)

Committed: https://crrev.com/5f2cde61f6ff4a764b9b1c7d74a24ef6de815835
Cr-Commit-Position: refs/heads/master@{#440208}

[Mikhail, 2016-12-21 10:27:35]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 10:27:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-12-21 10:28:15]

Description was changed from

==========
[Sensors] Reland: Align sensor reading updates and 'onchange' notification with
rAF.

For all sensors new reading values are read and 'onchange' notfication is send
from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.

Before this change a timers were used and this could unnecessarily drain CPU and
battery.

BUG=668052
BUG=606766

Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}

patch from issue 2551223003 at patchset 140001
(http://crrev.com/2551223003#ps140001)
==========

to

==========
[Sensors] Reland: Align sensor reading updates and 'onchange' notification with
rAF.

For all sensors new reading values are read and 'onchange' notfication is send
from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.

Before this change a timers were used and this could unnecessarily drain CPU and
battery.

BUG=668052
BUG=606766

Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}

patch from issue 2551223003 at patchset 140001
(http://crrev.com/2551223003#ps140001)
==========

[Mikhail, 2016-12-21 10:28:15]

mikhail.pozdnyakov@intel.com changed reviewers:
+ alexander.shalamov@intel.com, haraken@chromium.org, reillyg@chromium.org

[Mikhail, 2016-12-21 10:28:35]

PTAL

[shalamov, 2016-12-21 10:41:03]

https://codereview.chromium.org/2589283003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js (right):

https://codereview.chromium.org/2589283003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js:203:
this.sensor_reading_timer_id_ = window.setInterval(() => {
Should we clear previous interval if addConfiguration called multiple times?
e.g. when there are two active JS sensor objects?

[haraken, 2016-12-21 11:44:45]

The previous patch was reverted because it broke Linux Leak bot, right?

Did you confirm the new CL fixes it? You can test the leak detector by:

$ ./run-webkit-tests --enable-leak-detection sensor/

[commit-bot: I haz the power, 2016-12-21 12:32:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 12:32:15]

Dry run: This issue passed the CQ dry run.

[Mikhail, 2016-12-21 13:04:51]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 13:05:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-12-21 13:06:28]

https://codereview.chromium.org/2589283003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js (right):

https://codereview.chromium.org/2589283003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js:203:
this.sensor_reading_timer_id_ = window.setInterval(() => {
On 2016/12/21 10:41:03, shalamov wrote:
> Should we clear previous interval if addConfiguration called multiple times?
> e.g. when there are two active JS sensor objects?
Right, thanks for the catch!

[commit-bot: I haz the power, 2016-12-21 13:06:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 13:06:42]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Mikhail, 2016-12-21 13:11:42]

On 2016/12/21 11:44:45, haraken wrote:
> The previous patch was reverted because it broke Linux Leak bot, right?
> 
Yeah, shifting from timers to rAF caused some flakiness at 'frequency hint'
tests.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=se...

It is fixed now since the tests reference to the actual elapsed sensor updates
count instead of hardcoded values.

[Mikhail, 2016-12-21 13:14:11]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 13:14:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-12-21 13:14:38]

LGTM

[shalamov, 2016-12-21 13:19:25]

lgtm

[commit-bot: I haz the power, 2016-12-21 15:12:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 15:12:38]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2016-12-21 19:48:39]

lgtm

[Mikhail, 2016-12-21 20:46:55]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[commit-bot: I haz the power, 2016-12-21 20:47:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 20:58:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482353215356590,
"parent_rev": "fe12220f2f88142dc432e7cdc5df7eec348495fc", "commit_rev":
"67326a035e81b125b49f70a82c5fa6cf9029b9a4"}

[commit-bot: I haz the power, 2016-12-21 20:59:02]

Description was changed from

==========
[Sensors] Reland: Align sensor reading updates and 'onchange' notification with
rAF.

For all sensors new reading values are read and 'onchange' notfication is send
from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.

Before this change a timers were used and this could unnecessarily drain CPU and
battery.

BUG=668052
BUG=606766

Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}

patch from issue 2551223003 at patchset 140001
(http://crrev.com/2551223003#ps140001)
==========

to

==========
[Sensors] Reland: Align sensor reading updates and 'onchange' notification with
rAF.

For all sensors new reading values are read and 'onchange' notfication is send
from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.

Before this change a timers were used and this could unnecessarily drain CPU and
battery.

BUG=668052
BUG=606766

Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}

patch from issue 2551223003 at patchset 140001
(http://crrev.com/2551223003#ps140001)

Review-Url: https://codereview.chromium.org/2589283003
==========

[commit-bot: I haz the power, 2016-12-21 20:59:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-21 21:02:40]

Description was changed from

==========
[Sensors] Reland: Align sensor reading updates and 'onchange' notification with
rAF.

For all sensors new reading values are read and 'onchange' notfication is send
from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.

Before this change a timers were used and this could unnecessarily drain CPU and
battery.

BUG=668052
BUG=606766

Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}

patch from issue 2551223003 at patchset 140001
(http://crrev.com/2551223003#ps140001)

Review-Url: https://codereview.chromium.org/2589283003
==========

to

==========
[Sensors] Reland: Align sensor reading updates and 'onchange' notification with
rAF.

For all sensors new reading values are read and 'onchange' notfication is send
from rAF callbacks, thus avoiding possible Critical Rendering Path interruption.

Before this change a timers were used and this could unnecessarily drain CPU and
battery.

BUG=668052
BUG=606766

Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb
Cr-Commit-Position: refs/heads/master@{#439467}

patch from issue 2551223003 at patchset 140001
(http://crrev.com/2551223003#ps140001)

Committed: https://crrev.com/5f2cde61f6ff4a764b9b1c7d74a24ef6de815835
Cr-Commit-Position: refs/heads/master@{#440208}
==========

[commit-bot: I haz the power, 2016-12-21 21:02:41]

Patchset 4 (id:??) landed as
https://crrev.com/5f2cde61f6ff4a764b9b1c7d74a24ef6de815835
Cr-Commit-Position: refs/heads/master@{#440208}

[hcarmona, 2016-12-21 23:07:52]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2596063003/ by hcarmona@chromium.org.

The reason for reverting is: This looks like a likely cause of these failures:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu....