Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2596063003: Revert of [Sensors] Reland: Align sensor reading updates and 'onchange' notification with rAF. (Closed)

Created:
4 years ago by hcarmona
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, wanming.lin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sensors] Reland: Align sensor reading updates and 'onchange' notification with rAF. (patchset #4 id:60001 of https://codereview.chromium.org/2589283003/ ) Reason for revert: This looks like a likely cause of these failures: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/945 Original issue's description: > [Sensors] Reland: Align sensor reading updates and 'onchange' notification with rAF. > > For all sensors new reading values are read and 'onchange' notfication is send from rAF callbacks, thus avoiding possible Critical Rendering Path interruption. > > Before this change a timers were used and this could unnecessarily drain CPU and battery. > > BUG=668052 > BUG=606766 > > Committed: https://crrev.com/6b071fe7dc3bd64a2914eadd5c67b483d064a6cb > Cr-Commit-Position: refs/heads/master@{#439467} > > patch from issue 2551223003 at patchset 140001 (http://crrev.com/2551223003#ps140001) > > Committed: https://crrev.com/5f2cde61f6ff4a764b9b1c7d74a24ef6de815835 > Cr-Commit-Position: refs/heads/master@{#440208} TBR=alexander.shalamov@intel.com,haraken@chromium.org,reillyg@chromium.org,mikhail.pozdnyakov@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668052 Committed: https://crrev.com/e2f7eddb1030e053847378b4202416c807fa298e Cr-Commit-Position: refs/heads/master@{#440257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -262 lines) Patch
M third_party/WebKit/LayoutTests/sensor/accelerometer.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/gyroscope.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/magnetometer.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js View 4 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.h View 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 10 chunks +45 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.h View 7 chunks +12 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorProxy.cpp View 14 chunks +55 lines, -33 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/SensorReadingUpdater.h View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/SensorReadingUpdater.cpp View 1 chunk +0 lines, -112 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.h View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/sensor/SensorUpdateNotificationStrategy.cpp View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hcarmona
Created Revert of [Sensors] Reland: Align sensor reading updates and 'onchange' notification with rAF.
4 years ago (2016-12-21 23:07:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2596063003/1
4 years ago (2016-12-21 23:08:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 23:09:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e2f7eddb1030e053847378b4202416c807fa298e Cr-Commit-Position: refs/heads/master@{#440257}
4 years ago (2016-12-21 23:14:20 UTC) #8
haraken
LGTM
4 years ago (2016-12-22 00:23:16 UTC) #9
Mikhail
The given https://uberchromegw.corp.google.com is not available for non-googlers. Could I know somehow what were the ...
4 years ago (2016-12-22 10:07:27 UTC) #10
hcarmona
4 years ago (2016-12-22 18:09:08 UTC) #11
Message was sent while issue was closed.
On 2016/12/22 10:07:27, Mikhail wrote:
> The given https://uberchromegw.corp.google.com is not available for
> non-googlers. Could I know somehow what were the problems there with the
> reverted cl?

Sorry, did not realize URL was not accessible.

The failures are in webkit_tests

Regressions: Unexpected crashes (4)
  sensor/accelerometer.html [ Crash ]
  sensor/ambient-light-sensor.html [ Crash ]
  sensor/gyroscope.html [ Crash ]
  sensor/magnetometer.html [ Crash ]

Powered by Google App Engine
This is Rietveld 408576698