third_party/WebKit/LayoutTests/sensor/magnetometer.html - Issue 2589283003: [Sensors] Reland: Align sensor reading updates and 'onchange' notification with rAF.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/sensor/magnetometer.html

Issue 2589283003: [Sensors] Reland: Align sensor reading updates and 'onchange' notification with rAF. (Closed)

Patch Set: rebased Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/sensor/gyroscope.html ('k') | third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script src="../resources/mojo-helpers.js"></script>	4 <script src="../resources/mojo-helpers.js"></script>

5 <script src="resources/sensor-helpers.js"></script>	5 <script src="resources/sensor-helpers.js"></script>

6 <script src="resources/generic-sensor-tests.js"></script>	6 <script src="resources/generic-sensor-tests.js"></script>

7 <script>	7 <script>

8	8

9 'use strict';	9 'use strict';

10	10

11 if (!window.testRunner)	11 if (!window.testRunner)

12 debug('This test cannot be run without the TestRunner');	12 debug('This test cannot be run without the TestRunner');

13	13

14 const kDefaultReadingValueX = -19.2;	14 const kDefaultReadingValueX = -19.2;

15 const kDefaultReadingValueY = 12.1;	15 const kDefaultReadingValueY = 12.1;

16 const kDefaultReadingValueZ = -44.3;	16 const kDefaultReadingValueZ = -44.3;

17 var readsCount = 0;

18	17

19 function update_sensor_reading(buffer, expects_modified_reading) {	18 function update_sensor_reading(buffer, expects_modified_reading, readsCount) {

20 buffer[1] = window.performance.now();	19 buffer[1] = window.performance.now();

21 buffer[2] = kDefaultReadingValueX;	20 buffer[2] = kDefaultReadingValueX;

22 buffer[3] = kDefaultReadingValueY;	21 buffer[3] = kDefaultReadingValueY;

23 buffer[4] = kDefaultReadingValueZ;	22 buffer[4] = kDefaultReadingValueZ;

24 if (expects_modified_reading)	23 if (expects_modified_reading)

25 buffer[2] += readsCount;	24 buffer[2] += readsCount;

26

27 readsCount++;

28 }	25 }

29	26

30 function verify_sensor_reading(reading) {	27 function verify_sensor_reading(reading) {

31 return reading.x == kDefaultReadingValueX &&	28 return reading.x == kDefaultReadingValueX &&

32 reading.y == kDefaultReadingValueY &&	29 reading.y == kDefaultReadingValueY &&

33 reading.z == kDefaultReadingValueZ;	30 reading.z == kDefaultReadingValueZ;

34 }	31 }

35	32

36 runGenericSensorTests(Magnetometer, update_sensor_reading, verify_sensor_reading );	33 runGenericSensorTests(Magnetometer, update_sensor_reading, verify_sensor_reading );

37 </script>	34 </script>

OLD	NEW