Add shadow/corner radius to notifications (toasts and in-center).

Add shadow/corner radius to message center notifications.

Both toasts (standalone bubbles) and notifications inside the message center get new shadows.

BUG=676223, 624175
Committed: https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748
Cr-Commit-Position: refs/heads/master@{#441553}

[Evan Stade, 2017-01-04 18:29:20]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 18:29:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 19:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 19:07:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2017-01-04 21:02:17]

Description was changed from

==========
Add shadow/corner radius to notifications (toasts and in-center).

BUG=676223
==========

to

==========
Add shadow/corner radius to notifications (toasts and in-center).

BUG=676223,624175
==========

[Evan Stade, 2017-01-04 21:08:42]

Description was changed from

==========
Add shadow/corner radius to notifications (toasts and in-center).

BUG=676223,624175
==========

to

==========
Add shadow/corner radius to message center notifications.

Both toasts (standalone bubbles) and notifications inside the message center get
new shadows.

BUG=676223,624175
==========

[Evan Stade, 2017-01-04 21:08:42]

estade@chromium.org changed reviewers:
+ jamescook@chromium.org

[Evan Stade, 2017-01-04 21:12:23]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 21:12:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 21:19:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 21:19:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2017-01-04 23:07:57]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 23:08:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 23:16:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2017-01-05 00:08:07]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-01-05 00:08:47]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 00:09:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-01-05 00:11:07]

estade@chromium.org changed reviewers:
+ sky@chromium.org
- jamescook@chromium.org

[Evan Stade, 2017-01-05 00:11:41]

https://codereview.chromium.org/2589163003/diff/100001/ui/message_center/view...
File ui/message_center/views/message_view.cc (right):

https://codereview.chromium.org/2589163003/diff/100001/ui/message_center/view...
ui/message_center/views/message_view.cc:112:
std::unique_ptr<views::Painter>(views::Painter::CreateImagePainter(
see crbug.com/678371

[sky, 2017-01-05 00:39:17]

LGTM

https://codereview.chromium.org/2589163003/diff/100001/ui/gfx/shadow_util.cc
File ui/gfx/shadow_util.cc (right):

https://codereview.chromium.org/2589163003/diff/100001/ui/gfx/shadow_util.cc#...
ui/gfx/shadow_util.cc:81: ShadowDetails::ShadowDetails(const ShadowDetails&
other) {
Does = default; work here?

https://codereview.chromium.org/2589163003/diff/100001/ui/gfx/shadow_util.h
File ui/gfx/shadow_util.h (right):

https://codereview.chromium.org/2589163003/diff/100001/ui/gfx/shadow_util.h#n...
ui/gfx/shadow_util.h:28: static const ShadowDetails& Get(int elevation, int
radius);
move above members (functions before members).

[Evan Stade, 2017-01-05 00:51:15]

https://codereview.chromium.org/2589163003/diff/100001/ui/gfx/shadow_util.cc
File ui/gfx/shadow_util.cc (right):

https://codereview.chromium.org/2589163003/diff/100001/ui/gfx/shadow_util.cc#...
ui/gfx/shadow_util.cc:81: ShadowDetails::ShadowDetails(const ShadowDetails&
other) {
On 2017/01/05 00:39:17, sky wrote:
> Does = default; work here?

ah, that's nifty. Seems to work.

https://codereview.chromium.org/2589163003/diff/100001/ui/gfx/shadow_util.h
File ui/gfx/shadow_util.h (right):

https://codereview.chromium.org/2589163003/diff/100001/ui/gfx/shadow_util.h#n...
ui/gfx/shadow_util.h:28: static const ShadowDetails& Get(int elevation, int
radius);
On 2017/01/05 00:39:17, sky wrote:
> move above members (functions before members).

Done.

[Evan Stade, 2017-01-05 00:51:23]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-01-05 00:51:24]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2589163003/#ps120001
(title: "sky reviews")

[commit-bot: I haz the power, 2017-01-05 00:52:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 01:49:12]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1483577483890530,
"parent_rev": "5285d6fd7d634d9f3d772fbdd83c55af6efdfbf1", "commit_rev":
"a88e1ca16c1c698b9b54a4a43be5509a08bba3ac"}

[commit-bot: I haz the power, 2017-01-05 01:49:57]

Description was changed from

==========
Add shadow/corner radius to message center notifications.

Both toasts (standalone bubbles) and notifications inside the message center get
new shadows.

BUG=676223,624175
==========

to

==========
Add shadow/corner radius to message center notifications.

Both toasts (standalone bubbles) and notifications inside the message center get
new shadows.

BUG=676223,624175

Review-Url: https://codereview.chromium.org/2589163003
==========

[commit-bot: I haz the power, 2017-01-05 01:49:58]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2017-01-05 01:52:16]

Description was changed from

==========
Add shadow/corner radius to message center notifications.

Both toasts (standalone bubbles) and notifications inside the message center get
new shadows.

BUG=676223,624175

Review-Url: https://codereview.chromium.org/2589163003
==========

to

==========
Add shadow/corner radius to message center notifications.

Both toasts (standalone bubbles) and notifications inside the message center get
new shadows.

BUG=676223,624175

Committed: https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748
Cr-Commit-Position: refs/heads/master@{#441553}
==========

[commit-bot: I haz the power, 2017-01-05 01:52:18]

Patchset 7 (id:??) landed as
https://crrev.com/36f01b0163a66ba5174589f0e766ff80f28ae748
Cr-Commit-Position: refs/heads/master@{#441553}