Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2594613002: Quick view lazy load: initialize quick view element lazily. (Closed)

Created:
4 years ago by oka
Modified:
4 years ago
Reviewers:
oka1, fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Quick view lazy load: initialize quick view element lazily. Sped up files app launch speed by ~100ms (on Linux) by lazily loading files-quick-view and files-metadata-box elements. BUG=675536 TEST=manually. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0667c0d63e43c625009d47031fbe9929cdac9864 Cr-Commit-Position: refs/heads/master@{#440031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/elements/elements_bundle.html View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/quick_view_controller.js View 1 chunk +8 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
oka
PTAL.
4 years ago (2016-12-20 10:02:01 UTC) #5
fukino
lgtm
4 years ago (2016-12-21 05:32:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594613002/1
4 years ago (2016-12-21 05:40:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 05:46:50 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-21 05:49:00 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0667c0d63e43c625009d47031fbe9929cdac9864
Cr-Commit-Position: refs/heads/master@{#440031}

Powered by Google App Engine
This is Rietveld 408576698