Media Controls: change how the MediaControls object is created and handled.

Media Controls: change how the MediaControls object is created and handled.

The HTMLMediaElement no longer adds the MediaControls to the shadow tree
in order to prepare for the class to be an interface implemented by
modules. This CL also removes a couple of reset() call.

BUG=662761
R=zqzhang@chromium.org

Committed: https://crrev.com/a0651819997c475b2ed28428e0fb81e72c82eab8
Cr-Commit-Position: refs/heads/master@{#439811}

[mlamouri (slow - plz ping), 2016-12-19 18:40:14]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[mlamouri (slow - plz ping), 2016-12-19 18:40:16]

PTAL

[commit-bot: I haz the power, 2016-12-19 18:40:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 21:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 21:59:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhiqiang Zhang (Slow), 2016-12-20 12:16:46]

lgtm w/ nit

Now the controls are getting much cleaner :)

https://codereview.chromium.org/2588823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/shadow/MediaControls.cpp (left):

https://codereview.chromium.org/2588823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/shadow/MediaControls.cpp:357:
m_fullscreenButton->setIsFullscreen(mediaElement().isFullscreen());
nit: why move this to FullscreenButton::create() but not for the other elements?

[mlamouri (slow - plz ping), 2016-12-20 13:35:42]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-12-20 13:35:43]

The patchset sent to the CQ was uploaded after l-g-t-m from zqzhang@chromium.org
Link to the patchset: https://codereview.chromium.org/2588823002/#ps20001
(title: "fix tests")

[commit-bot: I haz the power, 2016-12-20 13:35:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2016-12-20 13:36:24]

https://codereview.chromium.org/2588823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/shadow/MediaControls.cpp (left):

https://codereview.chromium.org/2588823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/shadow/MediaControls.cpp:357:
m_fullscreenButton->setIsFullscreen(mediaElement().isFullscreen());
On 2016/12/20 at 12:16:46, Zhiqiang Zhang wrote:
> nit: why move this to FullscreenButton::create() but not for the other
elements?

I moved this here in my previous CL. I realised it was only needed at creation
time and I want to reduce the number of things we do on ::reset().

[commit-bot: I haz the power, 2016-12-20 15:55:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482240942830860,
"parent_rev": "e68a844c6b24ca3c46f080cee08cdf9171c97710", "commit_rev":
"0307b64678a7f1cf69aa85aa6ab19688ef5fa050"}

[commit-bot: I haz the power, 2016-12-20 15:56:13]

Description was changed from

==========
Media Controls: change how the MediaControls object is created and handled.

The HTMLMediaElement no longer adds the MediaControls to the shadow tree
in order to prepare for the class to be an interface implemented by
modules. This CL also removes a couple of reset() call.

BUG=662761
R=zqzhang@chromium.org
==========

to

==========
Media Controls: change how the MediaControls object is created and handled.

The HTMLMediaElement no longer adds the MediaControls to the shadow tree
in order to prepare for the class to be an interface implemented by
modules. This CL also removes a couple of reset() call.

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2588823002
==========

[commit-bot: I haz the power, 2016-12-20 15:56:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 15:59:37]

Description was changed from

==========
Media Controls: change how the MediaControls object is created and handled.

The HTMLMediaElement no longer adds the MediaControls to the shadow tree
in order to prepare for the class to be an interface implemented by
modules. This CL also removes a couple of reset() call.

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2588823002
==========

to

==========
Media Controls: change how the MediaControls object is created and handled.

The HTMLMediaElement no longer adds the MediaControls to the shadow tree
in order to prepare for the class to be an interface implemented by
modules. This CL also removes a couple of reset() call.

BUG=662761
R=zqzhang@chromium.org

Committed: https://crrev.com/a0651819997c475b2ed28428e0fb81e72c82eab8
Cr-Commit-Position: refs/heads/master@{#439811}
==========

[commit-bot: I haz the power, 2016-12-20 15:59:38]

Patchset 2 (id:??) landed as
https://crrev.com/a0651819997c475b2ed28428e0fb81e72c82eab8
Cr-Commit-Position: refs/heads/master@{#439811}