Media Controls: change how the MediaControls object is created and handled.

third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 122 matching lines @@
       m_hideMediaControlsTimer(this,
                                &MediaControls::hideMediaControlsTimerFired),
       m_hideTimerBehaviorFlags(IgnoreNone),
       m_isMouseOverControls(false),
       m_isPausedForScrubbing(false),
       m_panelWidthChangedTimer(this,
                                &MediaControls::panelWidthChangedTimerFired),
       m_panelWidth(0),
       m_keepShowingUntilTimerFires(false) {}
 
-MediaControls* MediaControls::create(HTMLMediaElement& mediaElement) {
+MediaControls* MediaControls::create(HTMLMediaElement& mediaElement,
+                                     ShadowRoot& shadowRoot) {
   MediaControls* controls = new MediaControls(mediaElement);
   controls->setShadowPseudoId(AtomicString("-webkit-media-controls"));
   controls->initializeControls();
+  controls->reset();
 
   // Initialize the orientation lock when going fullscreen feature.
   if (RuntimeEnabledFeatures::videoFullscreenOrientationLockEnabled() &&
       mediaElement.isHTMLVideoElement()) {
     controls->m_orientationLockDelegate =
         new MediaControlsOrientationLockDelegate(
             toHTMLVideoElement(mediaElement));
   }
 
+  shadowRoot.appendChild(controls);
   return controls;
 }
 
 // The media controls DOM structure looks like:
 //
 // MediaControls
 //     (-webkit-media-controls)
 // +-MediaControlOverlayEnclosureElement
 // |    (-webkit-media-controls-overlay-enclosure)
 // | +-MediaControlOverlayPlayButtonElement
@@ skipping 181 matching lines @@
 
   updateCurrentTimeDisplay();
 
   m_timeline->setDuration(duration);
   m_timeline->setPosition(mediaElement().currentTime());
 
   onVolumeChange();
   onTextTracksAddedOrRemoved();
 
   m_fullscreenButton->setIsWanted(shouldShowFullscreenButton(mediaElement()));
-  m_fullscreenButton->setIsFullscreen(mediaElement().isFullscreen());

[Zhiqiang Zhang (Slow), 2016/12/20 12:16:46]

nit: why move this to FullscreenButton::create() but not for the other elements?

[mlamouri (slow - plz ping), 2016/12/20 13:36:24]

I moved this here in my previous CL. I realised it was only needed at creation
time and I want to reduce the number of things we do on ::reset().

 
   refreshCastButtonVisibilityWithoutUpdate();
 
   m_downloadButton->setIsWanted(
       m_downloadButton->shouldDisplayDownloadButton());
 }
 
 LayoutObject* MediaControls::layoutObjectForTextTrackLayout() {
   return m_panel->layoutObject();
 }
@@ skipping 584 matching lines @@
   visitor->trace(m_overflowList);
   visitor->trace(m_castButton);
   visitor->trace(m_overlayCastButton);
   visitor->trace(m_mediaEventListener);
   visitor->trace(m_windowEventListener);
   visitor->trace(m_orientationLockDelegate);
   HTMLDivElement::trace(visitor);
 }
 
 }  // namespace blink