Media Controls: use events to enter/exit fullscreen.

Media Controls: use events to enter/exit fullscreen.

This is also adding MediaControlsMediaEventListener::mediaElement() and
always call `m_fullscreenButton->setIsFullscreen` in ::reset() to avoid
the dependency when the controls are first created.

BUG=662761
R=zqzhang@chromium.org

Committed: https://crrev.com/2c68be804b1f752a88b2c0e2e7a086945ef0494c
Cr-Commit-Position: refs/heads/master@{#439785}

[mlamouri (slow - plz ping), 2016-12-19 18:00:09]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 18:00:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 18:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 18:04:25]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mlamouri (slow - plz ping), 2016-12-19 18:40:07]

PTAL (will look at the breakage later)

[mlamouri (slow - plz ping), 2016-12-20 10:58:56]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 10:59:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2016-12-20 10:59:34]

PTAL, the breakage was because of the tree being broken.

[Zhiqiang Zhang (Slow), 2016-12-20 11:45:29]

lgtm w/ comment

https://codereview.chromium.org/2592443002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
(right):

https://codereview.chromium.org/2592443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp:88:
if (mediaElement().isFullscreen())
I think MediaControlsOrientationLockDelegate has similar logic for detecting
video going fullscreen?

Do we want to merge them someday? However I saw the old logic calling
did{Enter/Exit}Fullscreen only works when the video is the fullscreen element.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/Fullscreen...

[mlamouri (slow - plz ping), 2016-12-20 12:15:44]

https://codereview.chromium.org/2592443002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp
(right):

https://codereview.chromium.org/2592443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/shadow/MediaControlsMediaEventListener.cpp:88:
if (mediaElement().isFullscreen())
On 2016/12/20 at 11:45:29, Zhiqiang Zhang wrote:
> I think MediaControlsOrientationLockDelegate has similar logic for detecting
video going fullscreen?
> 
> Do we want to merge them someday?

I think having both listen to the event is fine. The
MediaControlsOrientationLockDelegate is fully autonomous that way.

> However I saw the old logic calling did{Enter/Exit}Fullscreen only works when
the video is the fullscreen element.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/Fullscreen...

I believe HTMLMediaElement::isFullscreen() does the same check. Did I miss
something?

[commit-bot: I haz the power, 2016-12-20 12:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 12:32:41]

Dry run: This issue passed the CQ dry run.

[mlamouri (slow - plz ping), 2016-12-20 13:26:14]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2016-12-20 13:26:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 13:30:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482240374064420,
"parent_rev": "b81fe119fe9f43fbddded06be250056795ab4b77", "commit_rev":
"7652a0642d78deb95791296277139888478ca28d"}

[commit-bot: I haz the power, 2016-12-20 13:31:08]

Description was changed from

==========
Media Controls: use events to enter/exit fullscreen.

This is also adding MediaControlsMediaEventListener::mediaElement() and
always call `m_fullscreenButton->setIsFullscreen` in ::reset() to avoid
the dependency when the controls are first created.

BUG=662761
R=zqzhang@chromium.org
==========

to

==========
Media Controls: use events to enter/exit fullscreen.

This is also adding MediaControlsMediaEventListener::mediaElement() and
always call `m_fullscreenButton->setIsFullscreen` in ::reset() to avoid
the dependency when the controls are first created.

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2592443002
==========

[commit-bot: I haz the power, 2016-12-20 13:31:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 13:33:26]

Description was changed from

==========
Media Controls: use events to enter/exit fullscreen.

This is also adding MediaControlsMediaEventListener::mediaElement() and
always call `m_fullscreenButton->setIsFullscreen` in ::reset() to avoid
the dependency when the controls are first created.

BUG=662761
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2592443002
==========

to

==========
Media Controls: use events to enter/exit fullscreen.

This is also adding MediaControlsMediaEventListener::mediaElement() and
always call `m_fullscreenButton->setIsFullscreen` in ::reset() to avoid
the dependency when the controls are first created.

BUG=662761
R=zqzhang@chromium.org

Committed: https://crrev.com/2c68be804b1f752a88b2c0e2e7a086945ef0494c
Cr-Commit-Position: refs/heads/master@{#439785}
==========

[commit-bot: I haz the power, 2016-12-20 13:33:27]

Patchset 2 (id:??) landed as
https://crrev.com/2c68be804b1f752a88b2c0e2e7a086945ef0494c
Cr-Commit-Position: refs/heads/master@{#439785}