[Predator] renamed "Result" to "Suspect"

[Predator] renamed "Result" to "Suspect"

BUG=644476
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2588513002
Committed: https://chromium.googlesource.com/infra/infra/+/0ff06cb8f8877d0296a2f387f443a782e28191d8

[wrengr, 2016-12-17 00:06:52]

Description was changed from

==========
[Predator] renamed "Result" to "Suspect"

BUG=644476
TBR=stgao@chromium.org
==========

to

==========
[Predator] renamed "Result" to "Suspect"

BUG=644476
TBR=stgao@chromium.org
==========

[wrengr, 2016-12-17 00:06:52]

wrengr@chromium.org changed reviewers:
+ inferno@chromium.org, katesonia@chromium.org, mbarbella@chromium.org
- stgao@chromium.org

[wrengr, 2016-12-17 00:07:18]

Another renaming, this one much more substantial. PTAL

[Martin Barbella, 2016-12-17 00:11:50]

Didn't check the individual file updates, but just wanted to chime in to say
that Suspect sounds much better to me overall.

[inferno, 2016-12-19 18:18:47]

lgtm

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/logl...
File
appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py
(right):

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/logl...
appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py:10:
from crash.suspect import Suspect
Did you mean Suspects there ?

[wrengr, 2016-12-19 18:22:49]

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/logl...
File
appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py
(right):

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/logl...
appengine/findit/crash/loglinear/changelist_features/test/min_distance_test.py:10:
from crash.suspect import Suspect
On 2016/12/19 18:18:47, inferno wrote:
> Did you mean Suspects there ?

Doesn't look like (since Suspects isn't used in this file). Duplication prolly
came from the merging of Result & MatchResult. Fixed.

[wrengr, 2016-12-19 18:22:55]

The CQ bit was checked by wrengr@chromium.org

[wrengr, 2016-12-19 18:23:03]

The CQ bit was unchecked by wrengr@chromium.org

[wrengr, 2016-12-19 18:23:14]

The CQ bit was checked by wrengr@chromium.org

[wrengr, 2016-12-19 18:23:14]

The patchset sent to the CQ was uploaded after l-g-t-m from inferno@chromium.org
Link to the patchset: https://codereview.chromium.org/2588513002/#ps20001
(title: "Removing redundant import")

[commit-bot: I haz the power, 2016-12-19 18:23:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 18:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 18:23:28]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[stgao, 2016-12-19 18:30:30]

stgao@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2016-12-19 18:30:31]

lgtm with nits

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/chan...
File appengine/findit/crash/changelist_classifier.py (right):

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/chan...
appengine/findit/crash/changelist_classifier.py:12: from crash.suspect import
Suspects
These two are confusing. What's the difference?

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/susp...
File appengine/findit/crash/suspect.py (right):

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/susp...
appengine/findit/crash/suspect.py:177: blame):
nit: not aligned

[wrengr, 2016-12-19 18:33:43]

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/chan...
File appengine/findit/crash/changelist_classifier.py (right):

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/chan...
appengine/findit/crash/changelist_classifier.py:12: from crash.suspect import
Suspects
On 2016/12/19 18:30:30, stgao (slow on Monday) wrote:
> These two are confusing. What's the difference?

One is an individual suspected CL (plus meta data). The other is a map from
revision IDs to their Suspect. Is being renamed in another CL (can be merged
into this one if desired)

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/susp...
File appengine/findit/crash/suspect.py (right):

https://codereview.chromium.org/2588513002/diff/1/appengine/findit/crash/susp...
appengine/findit/crash/suspect.py:177: blame):
On 2016/12/19 18:30:31, stgao (slow on Monday) wrote:
> nit: not aligned

Follows the 4-space indentation rule, which is allowed in as an alternative to
the alignment rule.

[wrengr, 2016-12-19 18:35:33]

The CQ bit was checked by wrengr@chromium.org

[commit-bot: I haz the power, 2016-12-19 18:35:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 18:44:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482172533393130,
"parent_rev": "cf744eebe468483f85160f3c7e553e75439115ed", "commit_rev":
"0ff06cb8f8877d0296a2f387f443a782e28191d8"}

[commit-bot: I haz the power, 2016-12-19 18:45:01]

Description was changed from

==========
[Predator] renamed "Result" to "Suspect"

BUG=644476
TBR=stgao@chromium.org
==========

to

==========
[Predator] renamed "Result" to "Suspect"

BUG=644476
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2588513002
Committed:
https://chromium.googlesource.com/infra/infra/+/0ff06cb8f8877d0296a2f387f443a...
==========

[commit-bot: I haz the power, 2016-12-19 18:45:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/0ff06cb8f8877d0296a2f387f443a...