Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: appengine/findit/crash/culprit.py

Issue 2588513002: [Predator] renamed "Result" to "Suspect" (Closed)
Patch Set: Removing redundant import Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/culprit.py
diff --git a/appengine/findit/crash/culprit.py b/appengine/findit/crash/culprit.py
index 63d111e0b15a8451f13d7c83ba2034066225c070..5b0046ceb5e8bcbfbe29b14926c7099efe54fc84 100644
--- a/appengine/findit/crash/culprit.py
+++ b/appengine/findit/crash/culprit.py
@@ -9,6 +9,9 @@ class Culprit(namedtuple('Culprit',
['project', 'components', 'cls', 'regression_range', 'algorithm'])):
"""The result of successfully identifying the culprit of a crash report.
+ That is, this is what ``Predator.FindCultprit`` returns. It encapsulates
+ all the information predator discovered during its various analyses.
+
Args:
project (str): the most-suspected project
components (list of str): the suspected crbug components.
@@ -89,8 +92,6 @@ class Culprit(namedtuple('Culprit',
'found_suspects': False,
}
"""
- # TODO(wrengr): will this auto-dropping of unnecessary fields cause
- # any issues for JSON serialization?
result = {}
result['found'] = (
bool(self.project) or

Powered by Google App Engine
This is Rietveld 408576698