[Predator] renamed "Result" to "Suspect"

appengine/findit/crash/component_classifier.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import namedtuple
 from collections import defaultdict
 import logging
 import re
 
 from crash.component import Component
@@ skipping 22 matching lines @@
     self.top_n = top_n
 
   def GetClassFromStackFrame(self, frame):
     """Determine which component is responsible for this frame."""
     for component in self.components:
       if component.MatchesStackFrame(frame):
         return component.component_name
 
     return ''
 
-  # TODO(wrengr): refactor this into a method on Result which returns
+  # TODO(wrengr): refactor this into a method on Suspect which returns
   # the cannonical frame (and documents why it's the one we return).
-  def GetClassFromResult(self, result):
-    """Determine which component is responsible for this result.
+  def GetClassFromSuspect(self, suspect):
+    """Determine which component is responsible for this suspect.
 
-    Note that Findit assumes files that the culprit result touched come from
+    Note that Findit assumes files that the culprit suspect touched come from
     the same component.
     """
-    if result.file_to_stack_infos:
+    if suspect.file_to_stack_infos:
       # file_to_stack_infos is a dict mapping file_path to stack_infos,
       # where stack_infos is a list of (frame, callstack_priority)
       # pairs. So ``.values()`` returns a list of the stack_infos in an
       # arbitrary order; the first ``[0]`` grabs the "first" stack_infos;
       # the second ``[0]`` grabs the first pair from the list; and
       # the third ``[0]`` grabs the ``frame`` from the pair.
       # TODO(wrengr): why is that the right frame to look at?
-      frame = result.file_to_stack_infos.values()[0][0][0]
+      frame = suspect.file_to_stack_infos.values()[0][0][0]
       return self.GetClassFromStackFrame(frame)
 
     return ''
 
   # TODO(http://crbug.com/657177): return the Component objects
   # themselves, rather than strings naming them.
-  def Classify(self, results, crash_stack):
+  def Classify(self, suspects, crash_stack):
     """Classifies component of a crash.
 
     Args:
-      results (list of Result): Culprit results.
+      suspects (list of Suspect): Culprit suspects.
       crash_stack (CallStack): The callstack that caused the crash.
 
     Returns:
       List of top 2 components.
     """
-    # If ``results`` are available, we use the components from there since
+    # If ``suspects`` are available, we use the components from there since
     # they're more reliable than the ones from the ``crash_stack``.
-    if results:
-      classes = map(self.GetClassFromResult, results[:self.top_n])
+    if suspects:
+      classes = map(self.GetClassFromSuspect, suspects[:self.top_n])
     else:
       classes = map(self.GetClassFromStackFrame,
           crash_stack.frames[:self.top_n])
 
     return RankByOccurrence(classes, 2)
 
   # TODO(ymzhang): use component of new path as default. RENAME might
   # need to return two (old path new path may have different components)
   def GetClassFromFileChangeInfo(self, file_change_info):
     """Determine which component is responsible for a touched file."""
@@ skipping 18 matching lines @@
        top_n: number of components assigned to this change log, default is 2
 
      Returns:
        List of components
      """
     if not change_log:
       return None
 
     classes = map(self.GetClassFromFileChangeInfo, change_log.touched_files)
     return RankByOccurrence(classes, top_n, rank_function=lambda x:-len(x))