Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Issue 2587733002: Specify TaskType of posted Task explicitly in Sensor API (11) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken, Mikhail
CC:
chromium-reviews, shalamov, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, wanming.lin, blink-reviews, Mikhail, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in Sensor API The spec specifies its own Sensor task source. https://w3c.github.io/sensors/#the-sensor-interface BUG=624696 Committed: https://crrev.com/605278fc336b96a3b896c38adc16eb72d387e938 Cr-Commit-Position: refs/heads/master@{#439430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 4 chunks +6 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
tzik
PTAL
4 years ago (2016-12-18 22:45:22 UTC) #7
haraken
LGTM
4 years ago (2016-12-19 00:13:03 UTC) #8
Mikhail
lgtm
4 years ago (2016-12-19 06:50:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587733002/1
4 years ago (2016-12-19 08:00:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 08:05:41 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-19 08:09:53 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/605278fc336b96a3b896c38adc16eb72d387e938
Cr-Commit-Position: refs/heads/master@{#439430}

Powered by Google App Engine
This is Rietveld 408576698