Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Issue 2587723002: Specify TaskType of posted Task explicitly in Presentation API (10) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in Presentation API The spec specifies its own Presentation task source. https://w3c.github.io/presentation-api/#common-idioms This CL assigns it to Presentation API-related tasks. BUG=624696 Committed: https://crrev.com/4296716929260ed75d3fbf78386ca5dcfb85b46d Cr-Commit-Position: refs/heads/master@{#439428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
tzik
PTAL
4 years ago (2016-12-18 14:42:22 UTC) #6
haraken
LGTM
4 years ago (2016-12-18 14:57:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587723002/1
4 years ago (2016-12-19 07:54:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-19 07:58:15 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-19 08:00:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4296716929260ed75d3fbf78386ca5dcfb85b46d
Cr-Commit-Position: refs/heads/master@{#439428}

Powered by Google App Engine
This is Rietveld 408576698