Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2584263002: Specify TaskType of posted Task explicitly in WebSQL (9) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in WebSQL The spec specifies its own DatabaseAccess task source. https://www.w3.org/TR/webdatabase/#processing-model BUG=624696 Committed: https://crrev.com/c153ad0c97c4d1b9a4a8b639aa665fa238671d03 Cr-Commit-Position: refs/heads/master@{#439425}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionClient.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 24 (16 generated)
tzik
PTAL
4 years ago (2016-12-18 14:42:06 UTC) #6
haraken
LGTM
4 years ago (2016-12-18 14:57:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584263002/20001
4 years ago (2016-12-18 23:33:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/88449)
4 years ago (2016-12-19 00:57:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584263002/20001
4 years ago (2016-12-19 05:16:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584263002/20001
4 years ago (2016-12-19 06:23:22 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 07:48:02 UTC) #22
commit-bot: I haz the power
4 years ago (2016-12-19 07:50:30 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c153ad0c97c4d1b9a4a8b639aa665fa238671d03
Cr-Commit-Position: refs/heads/master@{#439425}

Powered by Google App Engine
This is Rietveld 408576698