Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2587143002: [wasm] Add iterators for opcodes or offsets of one function (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add iterators for opcodes or offsets of one function We have the BytecodeIterator with next() and has_next() methods, and pc_offset() and current() accessors. This CL adds an interface to iterate over the opcodes or offsets in a C++ foreach loop. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2587143002 Cr-Commit-Position: refs/heads/master@{#41851} Committed: https://chromium.googlesource.com/v8/v8/+/6361f133ab7524e8717703ff6b16398046fb1560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -24 lines) Patch
M src/base/iterator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/wasm/ast-decoder.h View 3 chunks +53 lines, -14 lines 0 comments Download
M src/wasm/wasm-objects.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 2 chunks +23 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Clemens Hammacher
4 years ago (2016-12-19 19:46:30 UTC) #5
titzer
lgtm, neat!
4 years ago (2016-12-19 20:39:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587143002/1
4 years ago (2016-12-20 11:27:07 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 11:28:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6361f133ab7524e8717703ff6b16398046f...

Powered by Google App Engine
This is Rietveld 408576698