Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2586123003: [compiler] Emit source position also for the control input (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Emit source position also for the control input Before, source position information was only emitted for nodes contained in a block, which excluded calls that terminate a block. R=mstarzinger@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2586123003 Cr-Commit-Position: refs/heads/master@{#41847} Committed: https://chromium.googlesource.com/v8/v8/+/3bede2f79d325dadfd4fabe950feaf4122ede339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M src/compiler/instruction-selector.cc View 3 chunks +23 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Clemens Hammacher
4 years ago (2016-12-19 19:31:10 UTC) #5
titzer
lgtm, is it possible to write a test for this?
4 years ago (2016-12-19 20:41:53 UTC) #6
Clemens Hammacher
On 2016/12/19 at 20:41:53, titzer wrote: > lgtm, is it possible to write a test ...
4 years ago (2016-12-20 09:55:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586123003/1
4 years ago (2016-12-20 10:18:28 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-20 10:20:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3bede2f79d325dadfd4fabe950feaf4122e...

Powered by Google App Engine
This is Rietveld 408576698