Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2591653002: [wasm] Introduce WasmSharedModuleData and refactor other objects (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
titzer, Yang
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Introduce WasmSharedModuleData and refactor other objects The new object will hold information which is shared by all clones of a WasmCompiledModule, e.g. the decoded asm.js offset table, and in the future also breakpoints. From there, we can set them on each new instantiation of any clone. While already changing lots of the code base, I also renamed all getters from "get_foo" to "foo", to conform to the style guide. R=titzer@chromium.org, yangguo@chromium.org BUG=v8:5732 Review-Url: https://codereview.chromium.org/2591653002 Cr-Commit-Position: refs/heads/master@{#41862} Committed: https://chromium.googlesource.com/v8/v8/+/081ac37048676f7a55230b01603bf43cc5b55002

Patch Set 1 #

Patch Set 2 : Minor fixes #

Patch Set 3 : Fix SLOW_DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -337 lines) Patch
M src/api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/asmjs/asm-js.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/frames.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/isolate.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/messages.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/snapshot/code-serializer.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M src/value-serializer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/wasm/wasm-debug.cc View 1 3 chunks +4 lines, -28 lines 0 comments Download
M src/wasm/wasm-js.cc View 7 chunks +7 lines, -8 lines 0 comments Download
M src/wasm/wasm-module.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/wasm/wasm-module.cc View 27 chunks +101 lines, -113 lines 0 comments Download
M src/wasm/wasm-objects.h View 1 16 chunks +85 lines, -41 lines 0 comments Download
M src/wasm/wasm-objects.cc View 21 chunks +190 lines, -102 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/wasm/test-wasm-breakpoints.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 2 chunks +13 lines, -7 lines 0 comments Download
M test/common/wasm/wasm-module-runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (13 generated)
Clemens Hammacher
Yang, PTAL at the mini-change in src/snapshot/code-serializer.cc. Ben, all the rest ;)
4 years ago (2016-12-20 10:17:20 UTC) #7
titzer
On 2016/12/20 10:17:20, Clemens Hammacher wrote: > Yang, PTAL at the mini-change in src/snapshot/code-serializer.cc. > ...
4 years ago (2016-12-20 14:01:56 UTC) #12
titzer
On 2016/12/20 10:17:20, Clemens Hammacher wrote: > Yang, PTAL at the mini-change in src/snapshot/code-serializer.cc. > ...
4 years ago (2016-12-20 14:01:58 UTC) #13
Yang
src/snapshot lgtm.
4 years ago (2016-12-20 14:31:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2591653002/40001
4 years ago (2016-12-20 14:32:22 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-20 14:34:12 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/081ac37048676f7a55230b01603bf43cc5b...

Powered by Google App Engine
This is Rietveld 408576698