Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2586903002: [turbofan] Avoid allocation of temporary array of Nodes when generating calls. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid allocation of temporary array of Nodes when generating calls. BUG= Review-Url: https://codereview.chromium.org/2586903002 Cr-Commit-Position: refs/heads/master@{#41798} Committed: https://chromium.googlesource.com/v8/v8/+/52702e55aa3d3605b25f7096b76ffe3e0964a6bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -60 lines) Patch
M src/compiler/raw-machine-assembler.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +8 lines, -27 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 7 chunks +32 lines, -20 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Igor Sheludko
PTAL
4 years ago (2016-12-19 09:06:41 UTC) #4
Benedikt Meurer
lgtm
4 years ago (2016-12-19 11:29:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586903002/20001
4 years ago (2016-12-19 11:30:10 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-19 11:35:52 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/52702e55aa3d3605b25f7096b76ffe3e096...

Powered by Google App Engine
This is Rietveld 408576698