Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: test/unittests/compiler/instruction-selector-unittest.cc

Issue 2586903002: [turbofan] Avoid allocation of temporary array of Nodes when generating calls. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-run-native-calls.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/instruction-selector-unittest.cc
diff --git a/test/unittests/compiler/instruction-selector-unittest.cc b/test/unittests/compiler/instruction-selector-unittest.cc
index 224016c2fad02018ebe33b32ad40c5748b28a4a1..f5cdf3d30049f3395d1be0fdac4e70351bd3aaac 100644
--- a/test/unittests/compiler/instruction-selector-unittest.cc
+++ b/test/unittests/compiler/instruction-selector-unittest.cc
@@ -376,9 +376,9 @@ TARGET_TEST_F(InstructionSelectorTest, CallJSFunctionWithDeopt) {
m.UndefinedConstant());
// Build the call.
- Node* args[] = {receiver, m.UndefinedConstant(), m.Int32Constant(1), context};
- Node* call =
- m.CallNWithFrameState(descriptor, function_node, args, state_node);
+ Node* nodes[] = {function_node, receiver, m.UndefinedConstant(),
+ m.Int32Constant(1), context, state_node};
+ Node* call = m.CallNWithFrameState(descriptor, arraysize(nodes), nodes);
m.Return(call);
Stream s = m.Build(kAllExceptNopInstructions);
@@ -433,9 +433,9 @@ TARGET_TEST_F(InstructionSelectorTest, CallStubWithDeopt) {
m.UndefinedConstant());
// Build the call.
- Node* args[] = {function_node, receiver, context};
Node* stub_code = m.HeapConstant(callable.code());
- Node* call = m.CallNWithFrameState(descriptor, stub_code, args, state_node);
+ Node* nodes[] = {stub_code, function_node, receiver, context, state_node};
+ Node* call = m.CallNWithFrameState(descriptor, arraysize(nodes), nodes);
m.Return(call);
Stream s = m.Build(kAllExceptNopInstructions);
@@ -537,9 +537,9 @@ TARGET_TEST_F(InstructionSelectorTest, CallStubWithDeoptRecursiveFrameState) {
frame_state_parent);
// Build the call.
- Node* args[] = {function_node, receiver, context2};
Node* stub_code = m.HeapConstant(callable.code());
- Node* call = m.CallNWithFrameState(descriptor, stub_code, args, state_node);
+ Node* nodes[] = {stub_code, function_node, receiver, context2, state_node};
+ Node* call = m.CallNWithFrameState(descriptor, arraysize(nodes), nodes);
m.Return(call);
Stream s = m.Build(kAllExceptNopInstructions);
« no previous file with comments | « test/cctest/compiler/test-run-native-calls.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698