Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2586503003: s390: cleanup s390 opcode table (Closed)

Created:
4 years ago by john.yan
Modified:
4 years ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: cleanup s390 opcode table Cleanup s390 opcode table and add z13 new opcodes R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2586503003 Cr-Commit-Position: refs/heads/master@{#41820} Committed: https://chromium.googlesource.com/v8/v8/+/4c640be19bce9e64cec706793579011853846d9d

Patch Set 1 #

Patch Set 2 : make nbyteInstruction size as public #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1622 lines, -809 lines) Patch
M src/s390/assembler-s390.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/s390/constants-s390.h View 1 4 chunks +1610 lines, -803 lines 0 comments Download
M src/s390/disasm-s390.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/simulator-s390.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/s390/simulator-s390.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
john.yan
ptal
4 years ago (2016-12-16 20:09:41 UTC) #1
JaideepBajwa
lgtm
4 years ago (2016-12-19 15:59:26 UTC) #2
JoranSiu
On 2016/12/16 20:09:41, john.yan wrote: > ptal lgtm
4 years ago (2016-12-19 16:02:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586503003/20001
4 years ago (2016-12-19 17:14:31 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-19 18:42:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4c640be19bce9e64cec7067935790118538...

Powered by Google App Engine
This is Rietveld 408576698