Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2587113002: [assembler] Introduce assembler-inl.h (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[assembler] Introduce assembler-inl.h This moves the platform-specific distinction to one place, and allows to just include assembler-inl.h instead of macro-assembler.h to get the correct inline functions defined in assembler.h (e.g. RelocInfo::set_target_address). R=mstarzinger@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2587113002 Cr-Commit-Position: refs/heads/master@{#41843} Committed: https://chromium.googlesource.com/v8/v8/+/623300a6d84a8953a84bd75031c7b0d91d6f9beb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -43 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 2 chunks +1 line, -22 lines 0 comments Download
A src/assembler-inl.h View 1 chunk +32 lines, -0 lines 0 comments Download
M src/macro-assembler.h View 2 chunks +1 line, -20 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Clemens Hammacher
4 years ago (2016-12-19 19:24:05 UTC) #5
titzer
lgtm
4 years ago (2016-12-20 10:05:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2587113002/1
4 years ago (2016-12-20 10:06:08 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-20 10:07:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/623300a6d84a8953a84bd75031c7b0d91d6...

Powered by Google App Engine
This is Rietveld 408576698