Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2586093002: Specify TaskType of posted Task explicitly in MessagePort (3) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in MessagePort This CL assigns PostedMessage task type to onmessage event triggered by MessagePort::postMessage(). The spec says each MessagePort has its own queue. However, Blink is not yet ready to do it. TaskType::PostedMessage implies a single shared queue as an alternative. https://html.spec.whatwg.org/multipage/comms.html#message-ports BUG=624696 Committed: https://crrev.com/7961a34505d39310861f2b80ba8f1d32cd49555d Cr-Commit-Position: refs/heads/master@{#439382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
tzik
PTAL
4 years ago (2016-12-18 13:45:40 UTC) #5
haraken
LGTM
4 years ago (2016-12-18 13:47:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586093002/1
4 years ago (2016-12-18 22:33:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-18 22:38:16 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-18 22:39:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7961a34505d39310861f2b80ba8f1d32cd49555d
Cr-Commit-Position: refs/heads/master@{#439382}

Powered by Google App Engine
This is Rietveld 408576698