Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2584233002: Specify TaskType of posted Task explicitly in FileAPIs (4) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, tzik, sof, eae+blinkwatch, nhiroki, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+fileapi, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in FileAPIs The spec says File API should use its own FileReading task source. https://w3c.github.io/FileAPI/#blobreader-task-source OTOH, FileSystem API spec doesn't specify the task source to use explicitly. However, since it's closely related to File API, FileSystem API should also use TaskType::FileReading. https://wicg.github.io/entries-api/ BUG=624696 Committed: https://crrev.com/10c4becea326eadf4fa3ffe2f65a05fde195dec5 Cr-Commit-Position: refs/heads/master@{#439383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
tzik
PTAL
4 years ago (2016-12-18 14:40:18 UTC) #7
haraken
LGTM
4 years ago (2016-12-18 14:52:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2584233002/1
4 years ago (2016-12-18 22:42:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-18 22:46:38 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-18 22:49:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10c4becea326eadf4fa3ffe2f65a05fde195dec5
Cr-Commit-Position: refs/heads/master@{#439383}

Powered by Google App Engine
This is Rietveld 408576698