Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2583003002: Specify TaskType of posted Task explicitly in Document (2) (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify TaskType of posted Task explicitly in Document This CL add explicit TaskTypes for tasks posted by Document itself. On Document::addConsoleMessage, since it's an Inspector message, this should not be throttled or suspended, so its TaskType should be Unthrottled. On Document::setAutofocusElement, the TaskType should be UserInteraction according to the spec: https://html.spec.whatwg.org/multipage/forms.html#autofocusing-a-form-control:-the-autofocus-attribute BUG=624696 Committed: https://crrev.com/eda496bacb9a4b17c3995473a3725bb5d19559f0 Cr-Commit-Position: refs/heads/master@{#439381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +6 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
tzik
PTAL
4 years ago (2016-12-18 13:16:14 UTC) #5
haraken
LGTM
4 years ago (2016-12-18 13:31:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583003002/1
4 years ago (2016-12-18 21:57:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-18 22:30:47 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-18 22:33:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eda496bacb9a4b17c3995473a3725bb5d19559f0
Cr-Commit-Position: refs/heads/master@{#439381}

Powered by Google App Engine
This is Rietveld 408576698